From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73988C4360C for ; Fri, 27 Sep 2019 13:10:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 53EAE21906 for ; Fri, 27 Sep 2019 13:10:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727205AbfI0NKL (ORCPT ); Fri, 27 Sep 2019 09:10:11 -0400 Received: from mx2.suse.de ([195.135.220.15]:46484 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727076AbfI0NKL (ORCPT ); Fri, 27 Sep 2019 09:10:11 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id EDC28AEB8; Fri, 27 Sep 2019 13:10:09 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 5EC82DA897; Fri, 27 Sep 2019 15:10:28 +0200 (CEST) Date: Fri, 27 Sep 2019 15:10:27 +0200 From: David Sterba To: Nikolay Borisov Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [PATCH 1/2] common/rc: Remove special handing of 'dup' argument for btrfs Message-ID: <20190927131027.GU2751@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Nikolay Borisov , fstests@vger.kernel.org, linux-btrfs@vger.kernel.org References: <20190927105233.14926-1-nborisov@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190927105233.14926-1-nborisov@suse.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Fri, Sep 27, 2019 at 01:52:32PM +0300, Nikolay Borisov wrote: > _scratch_pool_mkfs special cases the command executed when 'dup' option > is used when creating a filesystem. This is wrong since 'dup' works > for all profiles and number of devices. This bug manifested while > exercising btrfs' balance argument combinations test. All profile combinations should be valid (mkfs, balance convert) since 4.5-ish, so Reviewed-by: David Sterba