From: David Sterba <dsterba@suse.cz>
To: dsterba@suse.cz, Nikolay Borisov <nborisov@suse.com>,
fdmanana@gmail.com, linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v2] btrfs: Properly handle backref_in_log retval
Date: Thu, 3 Oct 2019 15:07:56 +0200 [thread overview]
Message-ID: <20191003130756.GT2751@twin.jikos.cz> (raw)
In-Reply-To: <20191003125559.GS2751@twin.jikos.cz>
On Thu, Oct 03, 2019 at 02:55:59PM +0200, David Sterba wrote:
> On Thu, Sep 26, 2019 at 01:39:58PM +0300, Nikolay Borisov wrote:
> > >> - if (backref_in_log(log_root, &search_key, dirid, name, name_len))
> > >> + ret = backref_in_log(log_root, &search_key, dirid, name, name_len);
> > >> + if (ret == 1)
> > >> return true;
> > >
> > > This function also needs to be able to return errors and its caller
> > > check for errors.
> >
> > Yes but this is for a follow up patch. The current patch does not make
> > the code any more broken than it currently is.
>
> I'm going to merge the patches, please send the followup patch soon, so
> we don't forget about adding the proper error handling. Thanks.
Never mind, the patch 3/3 inlines the function and the error handling is
integrated to the caller.
next prev parent reply other threads:[~2019-10-03 13:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 14:44 [PATCH 0/3] Cleanup backref_in_log and its callers Nikolay Borisov
2019-08-30 14:44 ` [PATCH 1/3] btrfs: Don't opencode btrfs_find_name_in_backref in backref_in_log Nikolay Borisov
2019-09-24 17:09 ` David Sterba
2019-08-30 14:44 ` [PATCH 2/3] btrfs: Properly handle backref_in_log retval Nikolay Borisov
2019-09-24 17:09 ` David Sterba
2019-09-25 11:03 ` [PATCH v2] " Nikolay Borisov
2019-09-26 9:31 ` Filipe Manana
2019-09-26 10:39 ` Nikolay Borisov
2019-10-03 12:55 ` David Sterba
2019-10-03 13:07 ` David Sterba [this message]
2019-08-30 14:44 ` [PATCH 3/3] btrfs: Open-code name_in_log_ref in replay_one_name Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191003130756.GT2751@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fdmanana@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox