From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 804D3CA9EAF for ; Mon, 21 Oct 2019 13:43:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5CCA62053B for ; Mon, 21 Oct 2019 13:43:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729068AbfJUNnf (ORCPT ); Mon, 21 Oct 2019 09:43:35 -0400 Received: from mx2.suse.de ([195.135.220.15]:58228 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727322AbfJUNnf (ORCPT ); Mon, 21 Oct 2019 09:43:35 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id C8517B155; Mon, 21 Oct 2019 13:43:33 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id F3FC6DA8C5; Mon, 21 Oct 2019 15:43:46 +0200 (CEST) Date: Mon, 21 Oct 2019 15:43:46 +0200 From: David Sterba To: Anand Jain Cc: dsterba@suse.cz, linux-btrfs@vger.kernel.org Subject: Re: [PATCH v3] btrfs-progs: add verbose option to btrfs device scan Message-ID: <20191021134346.GL3001@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Anand Jain , linux-btrfs@vger.kernel.org References: <1569989512-5594-1-git-send-email-anand.jain@oracle.com> <20191007174129.GK2751@twin.jikos.cz> <20191014152457.GQ2751@twin.jikos.cz> <365faddf-cf4f-2a03-820d-d4f5071240e8@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <365faddf-cf4f-2a03-820d-d4f5071240e8@oracle.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Tue, Oct 15, 2019 at 11:29:34AM +0800, Anand Jain wrote: > I was thinking there might be some common code between the > sub-commands in btrfs-progs now or in future, and if the printf() > due to verbose is required in one sub-command and the same printf() > due to verbose is not required in another sub-command (which I > called unwanted message) then we won't have any choice to not > to print those unwanted printf(). > But as this is just an anticipatory only, so probably we could try > global verbose and see how it fares. I will try. I see, but it would be better to have a concrete example where it's problematic so we can figure out ways how to filter unwanted messages.