From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Subject: [RFC PATCH 3/3] btrfs-progs: receive: make quiet really quiet
Date: Thu, 24 Oct 2019 14:28:25 +0800 [thread overview]
Message-ID: <20191024062825.13097-4-anand.jain@oracle.com> (raw)
In-Reply-To: <20191024062825.13097-1-anand.jain@oracle.com>
A message is still being printed even when the receive option --quiet
is specified, this patch fixes it.
before:
---- btrfs receive -q -f /tmp/t /btrfs1 -----
At snapshot ss3
---- btrfs receive -f /tmp/t /btrfs1 -----
At snapshot ss3
after:
---- btrfs receive -q -f /tmp/t /btrfs1 -----
---- btrfs receive -f /tmp/t /btrfs1 -----
At snapshot ss3
Signed-off-by: Anand Jain <anand.jain@oracle.com>
fstests doesn't use --quiet option, so all test cases should remain
unaffected with this change.
---
cmds/receive.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/cmds/receive.c b/cmds/receive.c
index d8c934a7c57c..cc3df5c35821 100644
--- a/cmds/receive.c
+++ b/cmds/receive.c
@@ -269,7 +269,8 @@ static int process_snapshot(const char *path, const u8 *uuid, u64 ctransid,
goto out;
}
- fprintf(stdout, "At snapshot %s\n", path);
+ if (g_verbose)
+ fprintf(stdout, "At snapshot %s\n", path);
memcpy(rctx->cur_subvol.received_uuid, uuid, BTRFS_UUID_SIZE);
rctx->cur_subvol.stransid = ctransid;
--
2.23.0
next prev parent reply other threads:[~2019-10-24 6:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 6:28 [RFC PATCH 0/3] btrfs-progs: make quiet to overrule verbose Anand Jain
2019-10-24 6:28 ` [RFC PATCH 1/3] btrfs-progs: send: let option quiet " Anand Jain
2019-10-24 6:28 ` [RFC PATCH 2/3] btrfs-progs: receive: " Anand Jain
2019-10-24 6:28 ` Anand Jain [this message]
2019-10-24 15:41 ` [RFC PATCH 0/3] btrfs-progs: make quiet to " David Sterba
2019-10-24 23:51 ` Anand Jain
2019-10-25 1:56 ` Anand Jain
2019-10-25 16:35 ` David Sterba
2019-10-26 1:01 ` Anand Jain
2019-10-29 19:42 ` Anand Jain
2019-11-01 15:18 ` David Sterba
2019-11-04 6:26 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024062825.13097-4-anand.jain@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox