From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v4 2/2] btrfs: extent-tree: Ensure we trim ranges across block group boundary
Date: Fri, 25 Oct 2019 18:58:52 +0200 [thread overview]
Message-ID: <20191025165852.GS3001@twin.jikos.cz> (raw)
In-Reply-To: <20191025122353.uh63eb7ub77dyhyp@MacBook-Pro-91.local>
On Fri, Oct 25, 2019 at 08:23:54AM -0400, Josef Bacik wrote:
> > @@ -1341,10 +1351,19 @@ int btrfs_discard_extent(struct btrfs_fs_info *fs_info, u64 bytenr,
> > stripe->physical,
> > stripe->length,
> > &bytes);
> > - if (!ret)
> > + if (!ret) {
> > discarded_bytes += bytes;
> > - else if (ret != -EOPNOTSUPP)
> > - break; /* Logic errors or -ENOMEM, or -EIO but I don't know how that could happen JDM */
> > + } else if (ret != -EOPNOTSUPP) {
> > + /*
> > + * Logic errors or -ENOMEM, or -EIO but I don't
> > + * know how that could happen JDM
> > + *
> > + * Ans since there are two loops, explicitly
>
> Hate for there to be a v5 at this point, but it should be "and".
Fixed and the first sentence of the comment needed to be updated anyway.
prev parent reply other threads:[~2019-10-25 16:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 8:59 [PATCH v4 0/2] btrfs: trim: Fix a bug certain range may not be trimmed properly Qu Wenruo
2019-10-25 8:59 ` [PATCH v4 1/2] btrfs: volumes: Use more straightforward way to calculate map length Qu Wenruo
2019-10-25 12:17 ` Josef Bacik
2019-10-25 8:59 ` [PATCH v4 2/2] btrfs: extent-tree: Ensure we trim ranges across block group boundary Qu Wenruo
2019-10-25 12:23 ` Josef Bacik
2019-10-25 16:58 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025165852.GS3001@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox