From: Roman Mamedov <rm@romanrm.net>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [RFC PATCH] btrfs: rescue: Introduce new rescue mount option, rescue=skipdatacsum, to skip data csum verification
Date: Tue, 29 Oct 2019 11:53:17 +0500 [thread overview]
Message-ID: <20191029115317.03b43d94@natsu> (raw)
In-Reply-To: <20191029062149.217995-1-wqu@suse.com>
On Tue, 29 Oct 2019 14:21:49 +0800
Qu Wenruo <wqu@suse.com> wrote:
> Here we introduce a new rescue= mount option to completely skip data
> csum check.
> Since data csum check is completely skipped, for profiles with extra
> mirrors/copies, it will return the first copy only, which is not
> optimized, but should be good enough for rescue usage.
>
> This option only affects data csum verification, doesn't affect data
> csum calcuation, so new data write will still be protected by csum (if
> it doesn't get affected by csum tree corruption).
Maybe just make the "nodatasum" mount option skip verification of existing
checksums as well? Actually before seeing this patch I believed "nodatasum"
already does that.
Also for consistency note that datasum/nodatasum call it just "sum" in the
mount option name, not "csum".
--
With respect,
Roman
next prev parent reply other threads:[~2019-10-29 6:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 6:21 [RFC PATCH] btrfs: rescue: Introduce new rescue mount option, rescue=skipdatacsum, to skip data csum verification Qu Wenruo
2019-10-29 6:53 ` Roman Mamedov [this message]
2019-10-29 7:09 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191029115317.03b43d94@natsu \
--to=rm@romanrm.net \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox