From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C04BACA9ECF for ; Fri, 1 Nov 2019 11:27:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9EACF20656 for ; Fri, 1 Nov 2019 11:27:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727379AbfKAL10 (ORCPT ); Fri, 1 Nov 2019 07:27:26 -0400 Received: from mx2.suse.de ([195.135.220.15]:38574 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725904AbfKAL10 (ORCPT ); Fri, 1 Nov 2019 07:27:26 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 477AEAD5C; Fri, 1 Nov 2019 11:27:25 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id A724DDA783; Fri, 1 Nov 2019 12:27:33 +0100 (CET) Date: Fri, 1 Nov 2019 12:27:33 +0100 From: David Sterba To: Qu Wenruo Cc: linux-btrfs@vger.kernel.org Subject: Re: [PATCH] btrfs-progs: Fix block groups read which may skip certain block groups Message-ID: <20191101112733.GM3001@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Qu Wenruo , linux-btrfs@vger.kernel.org References: <20191030072711.73858-1-wqu@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191030072711.73858-1-wqu@suse.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Wed, Oct 30, 2019 at 03:27:11PM +0800, Qu Wenruo wrote: > Previous patch "btrfs-progs: Refactor btrfs_read_block_groups()" lacks a > fix which is in kernel counter part but not in btrfs-progs. > > It doesn't reset the key.offset used to search next block group, thus > btrfs-progs can skip certain block groups items. > > This can fail fsck/039 test case. > > Please fold this fix into that patch. Folded, thanks.