From: David Sterba <dsterba@suse.cz>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: David Sterba <dsterba@suse.com>,
Linux BTRFS Mailinglist <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs: remove unneeded check for btrfs_free_space_info in insert_into_bitmap()
Date: Tue, 5 Nov 2019 18:08:33 +0100 [thread overview]
Message-ID: <20191105170832.GN3001@twin.jikos.cz> (raw)
In-Reply-To: <20191105135127.17357-1-jthumshirn@suse.de>
On Tue, Nov 05, 2019 at 02:51:27PM +0100, Johannes Thumshirn wrote:
> The only caller for insert_into_bitmap() is __btrfs_add_free_space() and
> it takes care that the btrfs_free_space_info pointer passed to
> insert_into_bitmap() is allocated.
>
> Inside insert_into_bitmap() we're not freeing or NULLing this pointer
> anywhere, so checking if it is pre-allocated inside 'new_bitmap' label is
> pointless, so remove this check.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: David Sterba <dsterba@suse.com>
prev parent reply other threads:[~2019-11-05 17:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 13:51 [PATCH] btrfs: remove unneeded check for btrfs_free_space_info in insert_into_bitmap() Johannes Thumshirn
2019-11-05 17:08 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105170832.GN3001@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=dsterba@suse.com \
--cc=jthumshirn@suse.de \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox