From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH] btrfs: mkfs: Make no-holes as default mkfs incompat features
Date: Mon, 11 Nov 2019 14:50:04 +0800 [thread overview]
Message-ID: <20191111065004.24705-1-wqu@suse.com> (raw)
No-holes feature could save 53 bytes for each hole we have, and it
provides a pretty good workaround to prevent btrfs check from reporting
non-contiguous file extent holes for mixed direct/buffered IO.
The latter feature is more helpful for developers for handle log-writes
based test cases.
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
common/fsfeatures.c | 2 +-
common/fsfeatures.h | 5 +++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/common/fsfeatures.c b/common/fsfeatures.c
index 50934bd161b0..2028be9ad312 100644
--- a/common/fsfeatures.c
+++ b/common/fsfeatures.c
@@ -84,7 +84,7 @@ static const struct btrfs_fs_feature {
"no_holes",
VERSION_TO_STRING2(3,14),
VERSION_TO_STRING2(4,0),
- NULL, 0,
+ VERSION_TO_STRING2(5,4),
"no explicit hole extents for files" },
/* Keep this one last */
{ "list-all", BTRFS_FEATURE_LIST_ALL, NULL }
diff --git a/common/fsfeatures.h b/common/fsfeatures.h
index 3cc9452a3327..544daeeedf30 100644
--- a/common/fsfeatures.h
+++ b/common/fsfeatures.h
@@ -21,8 +21,9 @@
#define BTRFS_MKFS_DEFAULT_NODE_SIZE SZ_16K
#define BTRFS_MKFS_DEFAULT_FEATURES \
- (BTRFS_FEATURE_INCOMPAT_EXTENDED_IREF \
- | BTRFS_FEATURE_INCOMPAT_SKINNY_METADATA)
+ (BTRFS_FEATURE_INCOMPAT_EXTENDED_IREF | \
+ BTRFS_FEATURE_INCOMPAT_SKINNY_METADATA | \
+ BTRFS_FEATURE_INCOMPAT_NO_HOLES)
/*
* Avoid multi-device features (RAID56) and mixed block groups
--
2.24.0
next reply other threads:[~2019-11-11 6:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 6:50 Qu Wenruo [this message]
2019-11-11 18:02 ` [PATCH] btrfs: mkfs: Make no-holes as default mkfs incompat features David Sterba
2019-11-12 1:01 ` Qu Wenruo
2019-11-12 3:10 ` Anand Jain
2019-11-13 18:37 ` David Sterba
2019-11-27 17:10 ` David Sterba
2019-11-12 15:19 ` Filipe Manana
2019-11-13 1:12 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111065004.24705-1-wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox