From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8497AC432C3 for ; Thu, 14 Nov 2019 16:16:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6432F20672 for ; Thu, 14 Nov 2019 16:16:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726533AbfKNQQx (ORCPT ); Thu, 14 Nov 2019 11:16:53 -0500 Received: from mx2.suse.de ([195.135.220.15]:51048 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726339AbfKNQQx (ORCPT ); Thu, 14 Nov 2019 11:16:53 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id ED34BAD0F; Thu, 14 Nov 2019 16:16:51 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id AA98EDA774; Thu, 14 Nov 2019 17:16:54 +0100 (CET) Date: Thu, 14 Nov 2019 17:16:53 +0100 From: David Sterba To: Anand Jain Cc: linux-btrfs@vger.kernel.org Subject: Re: [PATCH v1 08/18] btrfs-progs: filesystem defragment: use global verbose option Message-ID: <20191114161653.GL3001@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Anand Jain , linux-btrfs@vger.kernel.org References: <1572849196-21775-1-git-send-email-anand.jain@oracle.com> <1572849196-21775-9-git-send-email-anand.jain@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1572849196-21775-9-git-send-email-anand.jain@oracle.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Mon, Nov 04, 2019 at 02:33:06PM +0800, Anand Jain wrote: > Transpire global --verbose option down to the btrfs receive sub-command. > > Suggested-by: David Sterba > Signed-off-by: Anand Jain > --- > cmds/filesystem.c | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/cmds/filesystem.c b/cmds/filesystem.c > index 4f22089abeaa..819b9fd1fcc5 100644 > --- a/cmds/filesystem.c > +++ b/cmds/filesystem.c > @@ -844,11 +844,12 @@ static const char * const cmd_filesystem_defrag_usage[] = { > "(e.g., files copied with 'cp --reflink', snapshots) which may cause", > "considerable increase of space usage. See btrfs-filesystem(8) for", > "more information.", > + HELPINFO_GLOBAL_OPTIONS_HEADER, > + HELPINFO_INSERT_VERBOSE, Please not that this needs to be put right after the command options, ie. before the paragraph.