Re: [PATCH 0/3] btrfs: More intelligent degraded chunk allocator

David Sterba
2019-11-18T20:18:36Z

On Thu, Nov 07, 2019 at 02:27:07PM +0800, Qu Wenruo wrote:
> This patchset will make btrfs degraded mount more intelligent and
> provide more consistent profile keeping function.
>
> One of the most problematic aspect of degraded mount is, btrfs may
> create unwanted profiles.
>
> # mkfs.btrfs -f /dev/test/scratch[12] -m raid1 -d raid1
> # wipefs -fa /dev/test/scratch2
> # mount -o degraded /dev/test/scratch1 /mnt/btrfs
> # fallocate -l 1G /mnt/btrfs/foobar
> # btrfs ins dump-tree -t chunk /dev/test/scratch1
> item 7 key (FIRST_CHUNK_TREE CHUNK_ITEM 1674575872) itemoff 15511 itemsize 80
> length 536870912 owner 2 stripe_len 65536 type DATA
> New data chunk will fallback to SINGLE or DUP.
>
>
> The cause is pretty simple, when mounted degraded, missing devices can't
> be used for chunk allocation.
> Thus btrfs has to fall back to SINGLE profile.
>
> This patchset will make btrfs to consider missing devices as last resort if
> current rw devices can't fulfil the profile request.
>
> This should provide a good balance between considering all missing
> device as RW and completely ruling out missing devices (current mainline
> behavior).

Thanks. This is going to change the behaviour with a missing device, so
the question is if we should make this configurable first and then
switch the default.

How does this work with scrub? Eg. if there are 2 devices in RAID1, one
goes missing and then scrub is started. It makes no sense to try to
repair the missing blocks, but given the logic in the patches all the
data will be rewritten, right?