Re: [PATCH] btrfs: Opencode ordered_data_tree_panic

[David Sterba <dsterba@suse.cz>]

On Fri, Nov 29, 2019 at 11:49:23AM +0200, Nikolay Borisov wrote:
> 
> 
> On 29.11.19 г. 11:38 ч., Nikolay Borisov wrote:
> > It's a simple wrapper over btrfs_panic and is called only once. Just
> > open code it.
> > 
> > Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> > ---
> >  fs/btrfs/extent-tree.c  |  5 +----
> >  fs/btrfs/ordered-data.c | 10 +---------
> >  2 files changed, 2 insertions(+), 13 deletions(-)
> > 
> > diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
> > index f68b38f44f0b..ab99ec6e188b 100644
> > --- a/fs/btrfs/extent-tree.c
> > +++ b/fs/btrfs/extent-tree.c
> > @@ -4172,11 +4172,8 @@ int btrfs_free_reserved_extent(struct btrfs_fs_info *fs_info,
> >  	struct btrfs_block_group *cache;
> >  
> >  	cache = btrfs_lookup_block_group(fs_info, start);
> > -	if (!cache) {
> > -		btrfs_err(fs_info, "Unable to find block group for %llu",
> > -			  start);
> > +	if (!cache)
> >  		return -ENOSPC;
> > -	}
> >  
> >  	btrfs_add_free_space(cache, start, len);
> >  	btrfs_free_reserved_bytes(cache, len, delalloc);
> 
> Grrr this hunk should be dropped.... Shall I resend ?

No, i'll drop it