Re: [PATCH v5 03/28] btrfs: Check and enable HMZONED mode

David Sterba
2019-12-05T15:28:13Z

On Thu, Dec 05, 2019 at 02:17:04PM +0900, Naohiro Aota wrote:
> >I have a question, you wrote you check for a file system consisting of zoned
> >devices with equal zone size. What happens if you create a multi device file
> >system combining zoned and regular devices? Is this even supported and if no
> >where are the checks for it?
>
> We don't allow creaing a file system mixed with zoned and regular device.
> This is checked by btrfs_check_hmzoned_mode() (called from open_ctree()) at
> the mount time. "if (hmzoned_devices != nr_devices) { ... }" is doing the
> actual check.

It's ok for first implementation to have more restrictions, like not
allowing mixing hmzoned and regular devices or hmzoned devices with
different zone sizes. Adding that later should be possible and not
complicating the review for now.