[PATCH 19/44] btrfs: hold a ref on the root in btrfs_search_path_in_tree

Josef Bacik
2019-12-06T14:46:18Z

We look up an arbitrary fs root, we need to hold a ref on it while we're
doing our search.

Signed-off-by: Josef Bacik <josef@toxicpanda.com>
---
fs/btrfs/ioctl.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index e01363cd2bbe..b8b5432423e6 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -2328,6 +2328,12 @@ static noinline int btrfs_search_path_in_tree(struct btrfs_fs_info *info,
root = btrfs_get_fs_root(info, &key, true);
if (IS_ERR(root)) {
ret = PTR_ERR(root);
+ root = NULL;
+ goto out;
+ }
+ if (!btrfs_grab_fs_root(root)) {
+ ret = -ENOENT;
+ root = NULL;
goto out;
}

@@ -2378,6 +2384,8 @@ static noinline int btrfs_search_path_in_tree(struct btrfs_fs_info *info,
name[total_len] = '\0';
ret = 0;
out:
+ if (root)
+ btrfs_put_fs_root(root);
btrfs_free_path(path);
return ret;
}
--
2.23.0