From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 872A9C43603 for ; Wed, 11 Dec 2019 01:57:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6393F205C9 for ; Wed, 11 Dec 2019 01:57:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727078AbfLKB50 (ORCPT ); Tue, 10 Dec 2019 20:57:26 -0500 Received: from mail104.syd.optusnet.com.au ([211.29.132.246]:38614 "EHLO mail104.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726417AbfLKB50 (ORCPT ); Tue, 10 Dec 2019 20:57:26 -0500 Received: from dread.disaster.area (pa49-195-139-249.pa.nsw.optusnet.com.au [49.195.139.249]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 3E8AC82004B; Wed, 11 Dec 2019 12:57:22 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1ierFh-00073s-0t; Wed, 11 Dec 2019 12:57:21 +1100 Date: Wed, 11 Dec 2019 12:57:21 +1100 From: Dave Chinner To: Goldwyn Rodrigues Cc: linux-btrfs@vger.kernel.org, hch@infradead.org, darrick.wong@oracle.com, fdmanana@kernel.org, nborisov@suse.com, dsterba@suse.cz, jthumshirn@suse.de, linux-fsdevel@vger.kernel.org, Goldwyn Rodrigues Subject: Re: [PATCH 3/8] iomap: Remove lockdep_assert_held() Message-ID: <20191211015720.GF19213@dread.disaster.area> References: <20191210230155.22688-1-rgoldwyn@suse.de> <20191210230155.22688-4-rgoldwyn@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191210230155.22688-4-rgoldwyn@suse.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=W5xGqiek c=1 sm=1 tr=0 a=KoypXv6BqLCQNZUs2nCMWg==:117 a=KoypXv6BqLCQNZUs2nCMWg==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=pxVhFHJ0LMsA:10 a=iox4zFpeAAAA:8 a=7-415B0cAAAA:8 a=cJ-UA4PGj-_oL9fv718A:9 a=CjuIK1q_8ugA:10 a=WzC6qhA0u3u7Ye7llzcV:22 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Tue, Dec 10, 2019 at 05:01:50PM -0600, Goldwyn Rodrigues wrote: > From: Goldwyn Rodrigues > > Filesystems such as btrfs can perform direct I/O without holding the > inode->i_rwsem in some of the cases like writing within i_size. > So, remove the check for lockdep_assert_held(). > > Signed-off-by: Goldwyn Rodrigues > --- > fs/iomap/direct-io.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c > index 1a3bf3bd86fb..41c1e7c20a1f 100644 > --- a/fs/iomap/direct-io.c > +++ b/fs/iomap/direct-io.c > @@ -415,8 +415,6 @@ iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter, > struct blk_plug plug; > struct iomap_dio *dio; > > - lockdep_assert_held(&inode->i_rwsem); > - > if (!count) > return 0; Please move this up into the existing callers so that we don't lose this debug check from those paths. Cheers, Dave. -- Dave Chinner david@fromorbit.com