public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: Qu Wenruo <quwenruo.btrfs@gmx.com>,
	fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
	wqu@suse.com
Subject: Re: [PATCHi RFC] fstest: btrfs/158 fix miss-aligned stripe and device
Date: Wed, 11 Dec 2019 14:33:02 +0100	[thread overview]
Message-ID: <20191211133302.GK3929@twin.jikos.cz> (raw)
In-Reply-To: <6025418e-25ce-19f9-3c53-6b094609098c@oracle.com>

On Wed, Dec 11, 2019 at 03:23:06PM +0800, Anand Jain wrote:
> > And I tend to remove the fail_make_request requirement from some tests,
> > and direct read with multiple try should be enough to trigger repair for
> > test btrfs/142 and btrfs/143.
> > 
> 
> > In fact, I don't believe your current fix is good enough to handle both
> > old and new mkfs.btrfs.
> 
>   It was designed to handle only forward compatible.

If possible the tests should be robust and check assumptions and also
not hardcode eg. fixed block offset values that could change for various
reasons. Forward compatibility makes it hard to test backports, not only
on enterprise kernels but also on older stable kernels. We're in a state
where developers have list of tests to ignore because they known to be
bogus or unreliable.

      parent reply	other threads:[~2019-12-11 13:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11  2:22 [PATCH] fstests: btrfs/157 btrfs/158: Prevent stripe offset to pollute golden output Qu Wenruo
2019-12-11  2:22 ` [PATCH] fstests: common: Allow user to keep $seqres.dmesg for all tests Qu Wenruo
2019-12-11  3:22 ` [PATCH] fstests: btrfs/157 btrfs/158: Prevent stripe offset to pollute golden output Qu WenRuo
2019-12-11  6:08   ` [PATCHi RFC] fstest: btrfs/158 fix miss-aligned stripe and device Anand Jain
2019-12-11  7:08     ` Qu Wenruo
2019-12-11  7:23       ` Anand Jain
2019-12-11  7:35         ` Qu Wenruo
2019-12-11 13:33         ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191211133302.GK3929@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=anand.jain@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox