From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH] btrfs: Fix bad comment on disk_bytenr of btrfs_file_extent_item
Date: Tue, 17 Dec 2019 14:48:39 +0800 [thread overview]
Message-ID: <20191217064839.5724-1-wqu@suse.com> (raw)
All btrfs_file_extent_item members don't take checksum size into
consideration.
This bad comment looks like from early days where inlined data checksum
(checksum is stored along with data) is being considered.
But the reality is, we never support inlined data checksum since btrfs
is mainlined.
Remove this dead comment, add a new comment explaining how data checksum is
stored, and remove the unnecessary data csum reference.
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
include/uapi/linux/btrfs_tree.h | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/include/uapi/linux/btrfs_tree.h b/include/uapi/linux/btrfs_tree.h
index 8e322e2c7e78..bfe6f38031a3 100644
--- a/include/uapi/linux/btrfs_tree.h
+++ b/include/uapi/linux/btrfs_tree.h
@@ -776,15 +776,16 @@ struct btrfs_file_extent_item {
__u8 type;
/*
- * disk space consumed by the extent, checksum blocks are included
- * in these numbers
+ * disk space consumed by the data extent.
+ * Checksum is stored in csum tree, thus no bytenr/length takes
+ * csum into consideration.
*
* At this offset in the structure, the inline extent data start.
*/
__le64 disk_bytenr;
__le64 disk_num_bytes;
/*
- * the logical offset in file blocks (no csums)
+ * the logical offset in file blocks
* this extent record is for. This allows a file extent to point
* into the middle of an existing extent on disk, sharing it
* between two snapshots (useful if some bytes in the middle of the
@@ -792,8 +793,8 @@ struct btrfs_file_extent_item {
*/
__le64 offset;
/*
- * the logical number of file blocks (no csums included). This
- * always reflects the size uncompressed and without encoding.
+ * the logical number of file blocks. This always reflects the size
+ * uncompressed and without encoding.
*/
__le64 num_bytes;
--
2.24.1
next reply other threads:[~2019-12-17 6:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 6:48 Qu Wenruo [this message]
2019-12-17 7:04 ` [PATCH] btrfs: Fix bad comment on disk_bytenr of btrfs_file_extent_item Su Yue
2019-12-17 9:57 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217064839.5724-1-wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox