From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH] btrfs-progs: ctree.h: Sync the comment for btrfs_file_extent_item
Date: Tue, 17 Dec 2019 14:52:40 +0800 [thread overview]
Message-ID: <20191217065240.5919-1-wqu@suse.com> (raw)
The comment about data checksum on disk_bytes is completely wrong.
Sync it with fixed kernel comment to avoid confusion.
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
ctree.h | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/ctree.h b/ctree.h
index 3e50d086..9459adf1 100644
--- a/ctree.h
+++ b/ctree.h
@@ -916,13 +916,16 @@ struct btrfs_file_extent_item {
u8 type;
/*
- * disk space consumed by the extent, checksum blocks are included
- * in these numbers
+ * disk space consumed by the data extent
+ * Data checksum is stored in csum tree, thus no bytenr/length takes
+ * csum into consideration.
+ *
+ * At this offset in the structure, the inline extent data starts.
*/
__le64 disk_bytenr;
__le64 disk_num_bytes;
/*
- * the logical offset in file blocks (no csums)
+ * the logical offset in file blocks
* this extent record is for. This allows a file extent to point
* into the middle of an existing extent on disk, sharing it
* between two snapshots (useful if some bytes in the middle of the
@@ -930,7 +933,8 @@ struct btrfs_file_extent_item {
*/
__le64 offset;
/*
- * the logical number of file blocks (no csums included)
+ * the logical number of file blocks. This always reflects the size
+ * uncompressed and without encoding.
*/
__le64 num_bytes;
--
2.24.1
next reply other threads:[~2019-12-17 6:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 6:52 Qu Wenruo [this message]
2019-12-17 7:05 ` [PATCH] btrfs-progs: ctree.h: Sync the comment for btrfs_file_extent_item Su Yue
2020-01-02 16:40 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217065240.5919-1-wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox