From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Marcos Paulo de Souza <marcos.souza.org@gmail.com>,
dsterba@suse.com, linux-btrfs@vger.kernel.org,
Marcos Paulo de Souza <mpdesouza@suse.com>,
wqu@suse.com
Subject: Re: [btrfs-progs PATCH 1/4] tests: common: Add check_dm_target_support helper
Date: Wed, 18 Dec 2019 16:58:12 +0100 [thread overview]
Message-ID: <20191218155812.GK3929@suse.cz> (raw)
In-Reply-To: <076b3709-c702-b7bf-cd03-276115aa5263@gmx.com>
On Wed, Dec 18, 2019 at 08:26:09AM +0800, Qu Wenruo wrote:
> > +# check if the targets passed as arguments are available, and if not just skip
> > +# the test
> > +check_dm_target_support()
> > +{
> > + for target in "$@"; do
> > + $SUDO_HELPER modprobe dm-$target >/dev/null 2>&1
>
> To utilize $SUDO_HELPER, we need to call setup_root_helper() in the
> first place, just like all the other $SUDO_HELPER users in `tests/common`.
>
> Although nowadays it feels a little unnecessary, since the functionality
> is introduced because I'm a lazybone who doesn't bother to startup a VM
> to do proper test, but uses current unprivileged user to utilize self tests.
>
> Maybe it's time to get rid of SUDO_HELPER ?
No, that should stay, my local testing relies on that heavily.
next prev parent reply other threads:[~2019-12-18 15:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 20:31 [btrfs-progs PATCH 0/4] tests: do not fail if dm-thin is missing Marcos Paulo de Souza
2019-12-17 20:31 ` [btrfs-progs PATCH 1/4] tests: common: Add check_dm_target_support helper Marcos Paulo de Souza
2019-12-18 0:26 ` Qu Wenruo
2019-12-18 15:58 ` David Sterba [this message]
2019-12-18 16:05 ` Marcos Paulo de Souza
2019-12-17 20:31 ` [btrfs-progs PATCH 2/4] tests: mkfs: 017: Use " Marcos Paulo de Souza
2019-12-18 0:26 ` Qu Wenruo
2019-12-17 20:31 ` [btrfs-progs PATCH 3/4] tests: mkfs: 005: " Marcos Paulo de Souza
2019-12-18 0:27 ` Qu Wenruo
2019-12-17 20:31 ` [btrfs-progs PATCH 4/4] tests: Do not fail is dmsetup is missing Marcos Paulo de Souza
2019-12-18 0:30 ` Qu Wenruo
2019-12-18 0:44 ` Marcos Paulo de Souza
2019-12-18 0:48 ` Qu Wenruo
2019-12-18 16:03 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218155812.GK3929@suse.cz \
--to=dsterba@suse.cz \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=marcos.souza.org@gmail.com \
--cc=mpdesouza@suse.com \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox