From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF915C2D0C2 for ; Fri, 3 Jan 2020 14:44:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD5E3222C4 for ; Fri, 3 Jan 2020 14:44:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727884AbgACOoq (ORCPT ); Fri, 3 Jan 2020 09:44:46 -0500 Received: from mx2.suse.de ([195.135.220.15]:36056 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725890AbgACOoq (ORCPT ); Fri, 3 Jan 2020 09:44:46 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 0BA87ACB1; Fri, 3 Jan 2020 14:44:45 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id CF8A0DA795; Fri, 3 Jan 2020 15:44:36 +0100 (CET) Date: Fri, 3 Jan 2020 15:44:36 +0100 From: David Sterba To: Dennis Zhou Cc: David Sterba , Chris Mason , Josef Bacik , Omar Sandoval , kernel-team@fb.com, linux-btrfs@vger.kernel.org Subject: Re: [PATCH 04/12] btrfs: make max async discard size tunable Message-ID: <20200103144436.GW3929@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Dennis Zhou , David Sterba , Chris Mason , Josef Bacik , Omar Sandoval , kernel-team@fb.com, linux-btrfs@vger.kernel.org References: <786ac88afbfaa7993449811b282ea8790ba02338.1577999991.git.dennis@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <786ac88afbfaa7993449811b282ea8790ba02338.1577999991.git.dennis@kernel.org> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Thu, Jan 02, 2020 at 04:26:38PM -0500, Dennis Zhou wrote: > -#define BTRFS_ASYNC_DISCARD_MAX_SIZE (SZ_64M) > +#define BTRFS_ASYNC_DISCARD_DFL_MAX_SIZE (SZ_64M) I'd prefer to spell DEFAULT, so changed it to that. The identifier would be long in both cases so let's pick the descriptive version.