From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 0/3] Fix transaction abort when rmdir'ing a subvol
Date: Fri, 3 Jan 2020 18:08:30 +0100 [thread overview]
Message-ID: <20200103170830.GC3929@twin.jikos.cz> (raw)
In-Reply-To: <20191218222029.49178-1-josef@toxicpanda.com>
On Wed, Dec 18, 2019 at 05:20:26PM -0500, Josef Bacik wrote:
> btrfs/004 with my new fsstress was sometimes failing with a transaction abort
> while trying to remove a root ref. This turned out to be because of how we stub
> out subvol links in snapshot'ed subvolumes. The specific steps are detailed in
> "btrfs: fix invalid removal of root ref", but they are relatively
> straightforward. A xfstest is forthcoming, I want to get an overnight run of
> fsstress with these patches in place to make sure there are no other
> rename+removal shenanigans left. With these patches we pass my basic test and
> no longer abort the transaction. Thanks,
Reviewed-by: David Sterba <dsterba@suse.com>
As 2 and 3 are the real fixes, independent of 1, I'll queue them for
next week's pull request.
prev parent reply other threads:[~2020-01-03 17:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 22:20 [PATCH 0/3] Fix transaction abort when rmdir'ing a subvol Josef Bacik
2019-12-18 22:20 ` [PATCH 1/3] btrfs: rework arguments for btrfs_unlink_subvol Josef Bacik
2019-12-18 22:20 ` [PATCH 2/3] btrfs: fix invalid removal of root ref Josef Bacik
2019-12-18 22:20 ` [PATCH 3/3] btrfs: do not delete mismatched root ref's Josef Bacik
2020-01-03 17:08 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200103170830.GC3929@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox