Re: [PATCH] btrfs: update devid after replace

David Sterba
2020-01-15T16:18:12Z

On Wed, Jan 15, 2020 at 04:22:50PM +0800, Anand Jain wrote:
> During the replace the target device temporarily assumes devid 0 before
> assigning the devid of the soruce device.
>
> In btrfs_dev_replace_finishing() we remove source sysfs devid using
> the function btrfs_sysfs_remove_devices_attr(), so after that call
> kobject_rename() to update the devid in the sysfs.
> This adds and calls btrfs_sysfs_update_devid() helper function to update
> the device id.
>
> This patch must be squashed with the patch
> [PATCH v4] btrfs: sysfs, add devid/dev_state kobject and attribute
> or its variant.
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
> David,
> I couldn't find the patch-series..
> [PATCH 0/4] btrfs, sysfs cleanup and add dev_state
> in your misc-next. And I believe there were changes like
> function rename and attribute list reorder in your workspace. So I am
> sending a fix-patch which must be squashed to the patch v4 4/4.

I had to remove the patch from misc-next as it prevented further
testing. The whole patchset can be found in branch
ext/anand/sysfs-devinfo on github repo. Once I test this patch I'll add
it back.