[PATCH 24/43] btrfs: hold a ref on the root in record_reloc_root_in_trans

Josef Bacik
2020-01-17T21:26:51Z

We are recording this root in the transaction, so we need to hold a ref
on it until we do that.

Signed-off-by: Josef Bacik <josef@toxicpanda.com>
---
fs/btrfs/relocation.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c
index 79430a4245b5..9b61fdc89af7 100644
--- a/fs/btrfs/relocation.c
+++ b/fs/btrfs/relocation.c
@@ -2604,15 +2604,20 @@ static int record_reloc_root_in_trans(struct btrfs_trans_handle *trans,
{
struct btrfs_fs_info *fs_info = reloc_root->fs_info;
struct btrfs_root *root;
+ int ret;

if (reloc_root->last_trans == trans->transid)
return 0;

root = read_fs_root(fs_info, reloc_root->root_key.offset);
+ if (!btrfs_grab_fs_root(root))
+ BUG();
BUG_ON(IS_ERR(root));
BUG_ON(root->reloc_root != reloc_root);
+ ret = btrfs_record_root_in_trans(trans, root);
+ btrfs_put_fs_root(root);

- return btrfs_record_root_in_trans(trans, root);
+ return ret;
}

static noinline_for_stack
--
2.24.1