From: David Sterba <dsterba@suse.cz>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Filipe Manana <fdmanana@kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-btrfs <linux-btrfs@vger.kernel.org>,
xfs <linux-xfs@vger.kernel.org>,
Filipe Manana <fdmanana@suse.com>,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH 1/2] fs: allow deduplication of eof block into the end of the destination file
Date: Wed, 22 Jan 2020 13:38:34 +0100 [thread overview]
Message-ID: <20200122123833.GZ3929@twin.jikos.cz> (raw)
In-Reply-To: <20200122003532.GR8257@magnolia>
On Tue, Jan 21, 2020 at 04:35:32PM -0800, Darrick J. Wong wrote:
> Urk, I never reviewed this, did I...
>
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Thanks, so with this we can proceed with merging, the question is how.
This is in generic fs/ code but not plain VFS and affecting only btrfs
and xfs. I suggest the following:
I'll take the patches to a branch separate from other btrfs patches, add
rev-by and stable tags and send an extra pull request to Linus.
Before that the branch can spend some time in btrfs' for-next among
other topic branches so there's linux-next exposure.
I don't mean to sidestep VFS maintainers, but previous remap changes
don't have Al Viro's signed-off either, so I hope that when at least
Darrick is fine with the proposed way then let's do it. If not, please
let me know.
next prev parent reply other threads:[~2020-01-22 12:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 18:26 [PATCH 0/2] Allow deduplication of the eof block when it is safe to do so fdmanana
2019-12-16 18:26 ` [PATCH 1/2] fs: allow deduplication of eof block into the end of the destination file fdmanana
2019-12-17 15:52 ` Josef Bacik
2020-01-07 16:23 ` Filipe Manana
2020-01-07 17:57 ` Darrick J. Wong
2020-01-08 11:36 ` Filipe Manana
2020-01-08 16:15 ` Darrick J. Wong
2020-01-09 19:00 ` Filipe Manana
2020-01-09 19:12 ` Darrick J. Wong
2020-01-14 14:36 ` Filipe Manana
2020-01-22 0:35 ` Darrick J. Wong
2020-01-22 12:38 ` David Sterba [this message]
2019-12-16 18:26 ` [PATCH 2/2] Btrfs: make deduplication with range including the last block work fdmanana
2019-12-17 15:54 ` Josef Bacik
2019-12-29 5:22 ` Zygo Blaxell
2020-01-07 16:18 ` Filipe Manana
2020-01-07 18:16 ` Zygo Blaxell
2020-01-08 11:42 ` Filipe Manana
2020-01-08 14:53 ` David Sterba
2020-01-23 17:37 ` [PATCH 0/2] Allow deduplication of the eof block when it is safe to do so David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122123833.GZ3929@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=darrick.wong@oracle.com \
--cc=fdmanana@kernel.org \
--cc=fdmanana@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox