Re: [PATCH V2 00/10] unify origanization structure of block group cache

[David Sterba <dsterba@suse.cz>]

On Wed, Dec 18, 2019 at 01:18:39PM +0800, damenly.su@gmail.com wrote:
> From: Su Yue <Damenly_Su@gmx.com>
> 
> In progs, block group caches are stored in btrfs_fs_info::block_group_cache
> whose type is cache_extent. All block group caches adding/finding/freeing
> are done in the misleading set/clear_extent_bits ways. However, kernel
> side uses red-black tree structure in btrfs_fs_info directly. The
> latter's structure is more reasonable and intuitive.
> 
> This patchset transforms structure of block group caches from cache_extent
> to red-black tree and list.
> 
> patch[1] handles error to avoid warning after reform.
> patch[2-6] are about rb tree reform things in preparation.
> patch[7-8] are about dirty block groups linked in transaction in preparation.
> patch[9] does replace works in action.
> patch[10] does cleanup.
> 
> This patchset passed progs tests and did not cause any regression.
> 
> ---
> Changelog:
> v2:
>    Adjust block group cache tree seach and lookup functions to
>    progs behaviors.
>    Use rbtree_postorder_for_each_entry_safe() in patch[9] (Qu WenRuo).
>    Add reviewed-by tags.
> 
> Su Yue (10):
>   btrfs-progs: handle error if btrfs_write_one_block_group() failed
>   btrfs-progs: block_group: add rb tree related memebers
>   btrfs-progs: port block group cache tree insertion and lookup
>     functions
>   btrfs-progs: reform the function block_group_cache_tree_search()
>   btrfs-progs: adjust ported block group lookup functions in kernel
>     version
>   btrfs-progs: abstract function btrfs_add_block_group_cache()
>   block-progs: block_group: add dirty_bgs list related memebers
>   btrfs-progs: pass @trans to functions touch dirty block groups
>   btrfs-progs: reform block groups caches structure
>   btrfs-progs: cleanups after block group cache reform

As the patches were reviewed by Qu, I've added them to devel. I've
folded patch 5 to 4 as suggested. Thanks.