From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9006C2D0DB for ; Fri, 24 Jan 2020 13:41:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B68782072C for ; Fri, 24 Jan 2020 13:41:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387990AbgAXNlO (ORCPT ); Fri, 24 Jan 2020 08:41:14 -0500 Received: from mx2.suse.de ([195.135.220.15]:34578 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387743AbgAXNlN (ORCPT ); Fri, 24 Jan 2020 08:41:13 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 4FCF6AF10; Fri, 24 Jan 2020 13:41:12 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id A4226DA730; Fri, 24 Jan 2020 14:40:55 +0100 (CET) Date: Fri, 24 Jan 2020 14:40:55 +0100 From: David Sterba To: Filipe Manana Cc: Qu Wenruo , linux-btrfs , dsterba@suse.cz, Filipe Manana Subject: Re: [PATCH] btrfs: scrub: Require mandatory block group RO for dev-replace Message-ID: <20200124134055.GH3929@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Filipe Manana , Qu Wenruo , linux-btrfs , Filipe Manana References: <20200123235820.20764-1-wqu@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Fri, Jan 24, 2020 at 09:24:50AM +0000, Filipe Manana wrote: > On Fri, Jan 24, 2020 at 12:07 AM Qu Wenruo wrote: > > Reported-by: Filipe Manana > > Fixes: 76a8efa171bf ("btrfs: Continue replace when set_block_ro failed") > > Fixes: b12de52896c0 ("btrfs: scrub: Don't check free space before marking a block group RO") > > Signed-off-by: Qu Wenruo > > Reviewed-by: Filipe Manana > > Now it looks good, thanks! Thank you both, patch on the way to 5.5-rc8 or 5.6 final.