From: Eryu Guan <guaneryu@gmail.com>
To: Josef Bacik <josef@toxicpanda.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/3] ltp/fsx: do size check after closeopen operation
Date: Sat, 1 Feb 2020 15:42:18 +0800 [thread overview]
Message-ID: <20200201074218.GB2697@desktop> (raw)
In-Reply-To: <20200107165542.70108-2-josef@toxicpanda.com>
On Tue, Jan 07, 2020 at 11:55:40AM -0500, Josef Bacik wrote:
> I was running down a i_size problem and was missing the failure until
> the next iteration of fsx operations because we do the file size check
> _after_ the closeopen operation. Move it after the closeopen operation
I think you mean "_before_" here? And that's why we move it _after_
closeopen?
Thanks,
Eryu
> so we can catch problems where the file gets messed up on disk.
>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> ---
> ltp/fsx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ltp/fsx.c b/ltp/fsx.c
> index 00001117..c74b13c2 100644
> --- a/ltp/fsx.c
> +++ b/ltp/fsx.c
> @@ -2211,10 +2211,10 @@ have_op:
> check_contents();
>
> out:
> - if (sizechecks && testcalls > simulatedopcount)
> - check_size();
> if (closeopen)
> docloseopen();
> + if (sizechecks && testcalls > simulatedopcount)
> + check_size();
> return 1;
> }
>
> --
> 2.23.0
>
next prev parent reply other threads:[~2020-02-01 7:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 16:55 [PATCH 0/3] Some fsx improvements Josef Bacik
2020-01-07 16:55 ` [PATCH 1/3] ltp/fsx: do size check after closeopen operation Josef Bacik
2020-02-01 7:42 ` Eryu Guan [this message]
2020-01-07 16:55 ` [PATCH 2/3] ltp/fsx: drop caches if we're doing closeopen Josef Bacik
2020-01-07 16:55 ` [PATCH 3/3] generic/521: add close+open operations to the fsx run Josef Bacik
2020-02-01 8:06 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200201074218.GB2697@desktop \
--to=guaneryu@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox