From: Christoph Hellwig <hch@infradead.org>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: "dsterba@suse.cz" <dsterba@suse.cz>,
Christoph Hellwig <hch@infradead.org>,
David Sterba <dsterba@suse.com>,
Nikolay Borisov <nborisov@suse.com>,
"linux-btrfs @ vger . kernel . org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v3 0/5] btrfs: remove buffer heads form superblock handling
Date: Mon, 3 Feb 2020 00:29:39 -0800 [thread overview]
Message-ID: <20200203082939.GA25604@infradead.org> (raw)
In-Reply-To: <SN4PR0401MB3598374A2D00E21C275E5ED59B070@SN4PR0401MB3598.namprd04.prod.outlook.com>
On Fri, Jan 31, 2020 at 01:43:19PM +0000, Johannes Thumshirn wrote:
>
> I have a local version now, where btrfs_read_dev_one_super() uses
> read_cache_page_gfp() and btrfs_scratch_superblocks() uses
> write_one_page() offloading all the I/O to the pagecache. So far this
> works as expected.
>
> Now when I started converting write_dev_supers() and friends I wasn't
> sure if I can/should mix up read_cache_page_gfp() and submit_bio_wait().
> I could also convert it to write_one_page() but this way we would loose
> integrity checking for the super block.
>
> Any advice?
You can mix it, although it needs some big fat comments explaining what
is going on there to the reader.
prev parent reply other threads:[~2020-02-03 8:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 15:59 [PATCH v3 0/5] btrfs: remove buffer heads form superblock handling Johannes Thumshirn
2020-01-27 15:59 ` [PATCH v3 1/5] btrfs: remove buffer heads from super block reading Johannes Thumshirn
2020-01-28 11:47 ` Christoph Hellwig
2020-01-30 10:12 ` Johannes Thumshirn
2020-01-27 15:59 ` [PATCH v3 2/5] btrfs: remove use of buffer_heads from superblock writeout Johannes Thumshirn
2020-01-28 11:52 ` Christoph Hellwig
2020-01-27 15:59 ` [PATCH v3 3/5] btrfs: remove btrfsic_submit_bh() Johannes Thumshirn
2020-01-27 15:59 ` [PATCH v3 4/5] btrfs: remove buffer_heads from btrfsic_process_written_block() Johannes Thumshirn
2020-01-27 15:59 ` [PATCH v3 5/5] btrfs: remove buffer_heads form superblock mirror integrity checking Johannes Thumshirn
2020-01-29 14:25 ` [PATCH v3 0/5] btrfs: remove buffer heads form superblock handling David Sterba
2020-01-30 11:23 ` Johannes Thumshirn
2020-01-30 12:15 ` David Sterba
2020-01-30 13:39 ` Christoph Hellwig
2020-01-30 15:53 ` Johannes Thumshirn
2020-01-30 15:56 ` Christoph Hellwig
2020-01-30 16:09 ` Johannes Thumshirn
2020-01-30 16:15 ` Christoph Hellwig
2020-01-30 16:16 ` David Sterba
2020-01-31 13:43 ` Johannes Thumshirn
2020-02-03 8:29 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203082939.GA25604@infradead.org \
--to=hch@infradead.org \
--cc=Johannes.Thumshirn@wdc.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox