From: Josef Bacik <josef@toxicpanda.com>
To: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: [PATCH 18/24] btrfs: drop the commit_cycles stuff for data reservations
Date: Mon, 3 Feb 2020 15:49:45 -0500 [thread overview]
Message-ID: <20200203204951.517751-19-josef@toxicpanda.com> (raw)
In-Reply-To: <20200203204951.517751-1-josef@toxicpanda.com>
This was an old wart left over from how we previously did data
reservations. Before we could have people race in and take a
reservation while we were flushing space, so we needed to make sure we
looped a few times before giving up. Now that we're using the ticketing
infrastructure we don't have to worry about this and can drop the logic
altogether.
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
---
fs/btrfs/space-info.c | 22 ++--------------------
1 file changed, 2 insertions(+), 20 deletions(-)
diff --git a/fs/btrfs/space-info.c b/fs/btrfs/space-info.c
index 225f7f8a0503..8c5543328ec4 100644
--- a/fs/btrfs/space-info.c
+++ b/fs/btrfs/space-info.c
@@ -859,7 +859,6 @@ static void priority_reclaim_data_space(struct btrfs_fs_info *fs_info,
int states_nr)
{
int flush_state = 0;
- int commit_cycles = 2;
while (!space_info->full) {
flush_space(fs_info, space_info, U64_MAX, ALLOC_CHUNK_FORCE);
@@ -870,21 +869,9 @@ static void priority_reclaim_data_space(struct btrfs_fs_info *fs_info,
}
spin_unlock(&space_info->lock);
}
-again:
- while (flush_state < states_nr) {
- u64 flush_bytes = U64_MAX;
-
- if (!commit_cycles) {
- if (states[flush_state] == FLUSH_DELALLOC_WAIT) {
- flush_state++;
- continue;
- }
- if (states[flush_state] == COMMIT_TRANS)
- flush_bytes = ticket->bytes;
- }
- flush_space(fs_info, space_info, flush_bytes,
- states[flush_state]);
+ while (flush_state < states_nr) {
+ flush_space(fs_info, space_info, U64_MAX, states[flush_state]);
spin_lock(&space_info->lock);
if (ticket->bytes == 0) {
spin_unlock(&space_info->lock);
@@ -893,11 +880,6 @@ static void priority_reclaim_data_space(struct btrfs_fs_info *fs_info,
spin_unlock(&space_info->lock);
flush_state++;
}
- if (commit_cycles) {
- commit_cycles--;
- flush_state = 0;
- goto again;
- }
}
static void wait_reserve_ticket(struct btrfs_fs_info *fs_info,
--
2.24.1
next prev parent reply other threads:[~2020-02-03 20:50 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 20:49 [PATCH 00/24][v3] Convert data reservations to the ticketing infrastructure Josef Bacik
2020-02-03 20:49 ` [PATCH 01/24] btrfs: change nr to u64 in btrfs_start_delalloc_roots Josef Bacik
2020-02-04 7:40 ` Nikolay Borisov
2020-02-03 20:49 ` [PATCH 02/24] btrfs: remove orig from shrink_delalloc Josef Bacik
2020-02-03 20:49 ` [PATCH 03/24] btrfs: handle U64_MAX for shrink_delalloc Josef Bacik
2020-02-03 20:49 ` [PATCH 04/24] btrfs: make shrink_delalloc take space_info as an arg Josef Bacik
2020-02-03 20:49 ` [PATCH 05/24] btrfs: make ALLOC_CHUNK use the space info flags Josef Bacik
2020-02-03 20:49 ` [PATCH 06/24] btrfs: call btrfs_try_granting_tickets when freeing reserved bytes Josef Bacik
2020-02-03 20:49 ` [PATCH 07/24] btrfs: call btrfs_try_granting_tickets when unpinning anything Josef Bacik
2020-02-03 20:49 ` [PATCH 08/24] btrfs: call btrfs_try_granting_tickets when reserving space Josef Bacik
2020-02-03 20:49 ` [PATCH 09/24] btrfs: use the btrfs_space_info_free_bytes_may_use helper for delalloc Josef Bacik
2020-02-03 20:49 ` [PATCH 10/24] btrfs: use btrfs_start_delalloc_roots in shrink_delalloc Josef Bacik
2020-02-03 20:49 ` [PATCH 11/24] btrfs: check tickets after waiting on ordered extents Josef Bacik
2020-02-03 20:49 ` [PATCH 12/24] btrfs: add flushing states for handling data reservations Josef Bacik
2020-02-03 20:49 ` [PATCH 13/24] btrfs: add the data transaction commit logic into may_commit_transaction Josef Bacik
2020-02-03 20:49 ` [PATCH 14/24] btrfs: add btrfs_reserve_data_bytes and use it Josef Bacik
2020-02-03 20:49 ` [PATCH 15/24] btrfs: use ticketing for data space reservations Josef Bacik
2020-02-03 20:49 ` [PATCH 16/24] btrfs: serialize data reservations if we are flushing Josef Bacik
2020-02-03 20:49 ` [PATCH 17/24] btrfs: use the same helper for data and metadata reservations Josef Bacik
2020-02-03 20:49 ` Josef Bacik [this message]
2020-02-04 7:39 ` [PATCH 18/24] btrfs: drop the commit_cycles stuff for data reservations Nikolay Borisov
2020-02-03 20:49 ` [PATCH 19/24] btrfs: don't pass bytes_needed to may_commit_transaction Josef Bacik
2020-02-04 7:42 ` Nikolay Borisov
2020-02-03 20:49 ` [PATCH 20/24] btrfs: don't force commit if we are data Josef Bacik
2020-02-04 7:43 ` Nikolay Borisov
2020-02-03 20:49 ` [PATCH 21/24] btrfs: run delayed iputs before committing the transaction for data Josef Bacik
2020-02-04 7:43 ` Nikolay Borisov
2020-02-03 20:49 ` [PATCH 22/24] btrfs: flush delayed refs when trying to reserve data space Josef Bacik
2020-02-03 20:49 ` [PATCH 23/24] btrfs: do async reclaim for data reservations Josef Bacik
2020-02-03 20:49 ` [PATCH 24/24] btrfs: add a comment explaining the data flush steps Josef Bacik
2020-02-04 9:47 ` Nikolay Borisov
2020-02-04 16:16 ` Josef Bacik
2020-02-04 9:48 ` [PATCH 00/24][v3] Convert data reservations to the ticketing infrastructure Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203204951.517751-19-josef@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox