public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: David Sterba <dsterba@suse.com>,
	linux-btrfs@vger.kernel.org,
	Chris Murphy <lists@colorremedies.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH] btrfs: print message when tree-log replay starts
Date: Thu, 6 Feb 2020 14:41:30 +0100	[thread overview]
Message-ID: <20200206134130.GV2654@twin.jikos.cz> (raw)
In-Reply-To: <f9291224-ec67-f54b-3b09-5938c81e1568@oracle.com>

On Thu, Feb 06, 2020 at 11:48:28AM +0800, Anand Jain wrote:
> On 2/6/20 11:45 AM, Anand Jain wrote:
> > On 2/6/20 12:12 AM, David Sterba wrote:
> >> There's no logged information about tree-log replay although this is
> >> something that points to previous unclean unmount. Other filesystems
> >> report that as well.
> >>
> >> Suggested-by: Chris Murphy <lists@colorremedies.com>
> >> CC: stable@vger.kernel.org # 4.4+
> >> Signed-off-by: David Sterba <dsterba@suse.com>
> >> ---
> >>   fs/btrfs/disk-io.c | 1 +
> >>   1 file changed, 1 insertion(+)
> >>
> >> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> >> index 28622de9e642..295d5ebc9d5e 100644
> >> --- a/fs/btrfs/disk-io.c
> >> +++ b/fs/btrfs/disk-io.c
> >> @@ -3146,6 +3146,7 @@ int __cold open_ctree(struct super_block *sb,
> >>       /* do not make disk changes in broken FS or nologreplay is given */
> >>       if (btrfs_super_log_root(disk_super) != 0 &&
> >>           !btrfs_test_opt(fs_info, NOLOGREPLAY)) {
> 
> 
> >> +        btrfs_info("start tree-log replay");
> 
> btrfs_info() needs struct btrfs_fs_info as first arg.

Doh, that's what I get when I take months old patches and only briefly
review them before sending.

  reply	other threads:[~2020-02-06 13:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-05 16:12 [PATCH] btrfs: print message when tree-log replay starts David Sterba
2020-02-06  3:45 ` Anand Jain
2020-02-06  3:48   ` Anand Jain
2020-02-06 13:41     ` David Sterba [this message]
2020-02-06  6:33 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200206134130.GV2654@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=anand.jain@oracle.com \
    --cc=dsterba@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=lists@colorremedies.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox