From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1B10C3F68F for ; Thu, 6 Feb 2020 13:47:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A60DE218AC for ; Thu, 6 Feb 2020 13:47:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728158AbgBFNrt (ORCPT ); Thu, 6 Feb 2020 08:47:49 -0500 Received: from mx2.suse.de ([195.135.220.15]:36124 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727361AbgBFNrs (ORCPT ); Thu, 6 Feb 2020 08:47:48 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 2EBFCAC23; Thu, 6 Feb 2020 13:47:47 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 074E3DA952; Thu, 6 Feb 2020 14:47:33 +0100 (CET) Date: Thu, 6 Feb 2020 14:47:33 +0100 From: David Sterba To: Anand Jain Cc: David Sterba , linux-btrfs@vger.kernel.org Subject: Re: [PATCH 2/8] btrfs: drop argument tree from submit_extent_page Message-ID: <20200206134733.GW2654@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Anand Jain , David Sterba , linux-btrfs@vger.kernel.org References: <150ff69f-996e-7cfb-02ad-2193224f9b49@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <150ff69f-996e-7cfb-02ad-2193224f9b49@oracle.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Thu, Feb 06, 2020 at 01:58:22PM +0800, Anand Jain wrote: > On 2/6/20 2:09 AM, David Sterba wrote: > > Now that we're sure the tree from argument is same as the one we can get > > from the page's inode io_tree, > > > > drop the redundant argument. > > I think there is/was a plan to drop the btree inode? should we need > this argument if the plan is still on? or any idea if it still can > be implemented without this argument? That's a question for the one implementing the btree inode removal. As there are several possible ways how to implement it, with different trade-offs and such, I can't forsee if this particula parameter will be useful or not. And keeping things around for theoretical needs of future patches has proven to not work so we've been removing such artifacts. The exception is of course for patchsets that are in active development and would have to revert the cleanups.