From: David Sterba <dsterba@suse.cz>
To: Marcos Paulo de Souza <mpdesouza@suse.de>
Cc: Nathan Chancellor <natechancellor@gmail.com>,
Marcos Paulo de Souza <marcos.souza.org@gmail.com>,
dsterba@suse.com, wqu@suse.com, linux-btrfs@vger.kernel.org,
hch@infradead.org, josef@toxicpanda.com,
Marcos Paulo de Souza <mpdesouza@suse.com>,
clang-built-linux@googlegroups.com
Subject: Re: [PATCHv3] btrfs: Introduce new BTRFS_IOC_SNAP_DESTROY_V2 ioctl
Date: Tue, 11 Feb 2020 20:39:18 +0100 [thread overview]
Message-ID: <20200211193918.GI2902@twin.jikos.cz> (raw)
In-Reply-To: <45c807f4298b22eaa1a89741bee67721fa0b0f80.camel@suse.de>
On Tue, Feb 11, 2020 at 03:57:21PM -0300, Marcos Paulo de Souza wrote:
> > We received a build report from the 0day bot when building with clang
> > that appears legitimate if I am reading everything correctly.
> >
> > ../fs/btrfs/ioctl.c:2867:4: warning: array index 4087 is past the end
> > of the array (which contains 4040 elements) [-Warray-bounds]
> > vol_args2->name[BTRFS_PATH_NAME_MAX] = '\0';
> > ^ ~~~~~~~~~~~~~~~~~~~
> > ../include/uapi/linux/btrfs.h:125:3: note: array 'name' declared here
> > char name[BTRFS_SUBVOL_NAME_MAX + 1];
> > ^
> > 1 warning generated.
>
> Sure, I will send a new patch to address this warning after this one
> gets merged, since this problem existed before this change. Thanks for
> the report!
Actually the warning is correct because you used a different macro:
BTRFS_PATH_NAME_MAX (4087) instead of BTRFS_SUBVOL_NAME_MAX (4039).
next prev parent reply other threads:[~2020-02-11 19:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 13:05 [PATCHv3] btrfs: Introduce new BTRFS_IOC_SNAP_DESTROY_V2 ioctl Marcos Paulo de Souza
2020-02-10 23:41 ` Nathan Chancellor
2020-02-11 18:57 ` Marcos Paulo de Souza
2020-02-11 19:39 ` David Sterba [this message]
2020-02-21 14:44 ` David Sterba
2020-02-21 16:05 ` Marcos Paulo de Souza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200211193918.GI2902@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clang-built-linux@googlegroups.com \
--cc=dsterba@suse.com \
--cc=hch@infradead.org \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=marcos.souza.org@gmail.com \
--cc=mpdesouza@suse.com \
--cc=mpdesouza@suse.de \
--cc=natechancellor@gmail.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox