public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Marc MERLIN <marc@merlins.org>
To: dsterba@suse.cz, Martin Steigerwald <martin@lichtvoll.de>,
	Josef Bacik <josef@toxicpanda.com>,
	linux-btrfs@vger.kernel.org, kernel-team@fb.com,
	Roman Mamedov <rm@romanrm.net>
Subject: Re: [PATCH] btrfs: do not zero f_bavail if we have available space
Date: Thu, 20 Feb 2020 13:46:49 -0800	[thread overview]
Message-ID: <20200220214649.GD26873@merlins.org> (raw)
In-Reply-To: <2656316.bop9uDDU3N@merkaba> <20200219225051.39ca1082@natsu> <20200219153652.GA26873@merlins.org>

Well, turns out this was a more serious bug than we thought.
With dm-thin overcommit, it causes this:
[1324107.675334] BTRFS info (device dm-13): forced readonly
[1324107.692909] BTRFS warning (device dm-13): Skipping commit of aborted transaction.
[1324107.717141] BTRFS: error (device dm-13) in cleanup_transaction:1828: errno=-5 IO failure
[1324107.743298] BTRFS info (device dm-13): delayed_refs has NO entry
[1324107.817671] device-mapper: thin: 252:9: switching pool to write mode
[1324108.662095] BTRFS error (device dm-13): bad tree block start, want 9050645626880 have 0
[1324108.694286] BTRFS error (device dm-13): bad tree block start, want 9050645626880 have 0

In other words, this broke my filesystem. I didn't try to see if it's damaged or just read-only,
but obviously, this isn't good.

New kernel should stop this from happening hopefully.

VG/dm details if you care:
  VG Name               vgds2
  System ID             
  Format                lvm2
  Metadata Areas        1
  Metadata Sequence No  88
  VG Access             read/write
  VG Status             resizable
  MAX LV                0
  Cur LV                8
  Open LV               7
  Max PV                0
  Cur PV                1
  Act PV                1
  VG Size               14.55 TiB
  PE Size               4.00 MiB
  Total PE              3815316
  Alloc PE / Size       3801146 / 14.50 TiB
  Free  PE / Size       14170 / 55.35 GiB
  VG UUID               pc1cTH-kFo7-g0Kz-dELp-j51s-1yOO-v20WIV
   
  --- Logical volume ---
  LV Name                thinpool2
  VG Name                vgds2
  LV UUID                rxJCsT-ImNv-ibvM-zOS0-Xzqv-O8AU-1STUH9
  LV Write Access        read/write
  LV Creation host, time gargamel.svh.merlins.org, 2018-07-26 08:42:51 -0700
  LV Pool metadata       thinpool2_tmeta
  LV Pool data           thinpool2_tdata
  LV Status              available
  # open                 8
  LV Size                14.50 TiB
  Allocated pool data    99.99%
  Allocated metadata     59.88%
  Current LE             3801088
  Segments               1
  Allocation             inherit
  Read ahead sectors     auto
  - currently set to     8192
  Block device           252:9

  LV Path                /dev/vgds2/ubuntu
  LV Name                ubuntu
  VG Name                vgds2
  LV UUID                y42AA8-5zfq-Vbmr-TNo9-g7rn-UbGf-KOnFrf
  LV Write Access        read/write
  LV Creation host, time gargamel.svh.merlins.org, 2018-07-26 23:22:18 -0700
  LV Pool name           thinpool2
  LV Status              available
  # open                 1
  LV Size                14.00 TiB
  Mapped size            60.26%
  Current LE             3670016
  Segments               1
  Allocation             inherit
  Read ahead sectors     auto
  - currently set to     8192
  Block device           252:13


-- 
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
 
Home page: http://marc.merlins.org/                       | PGP 7F55D5F27AAF9D08

  parent reply	other threads:[~2020-02-20 21:46 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-31 14:31 [PATCH] btrfs: do not zero f_bavail if we have available space Josef Bacik
2020-01-31 20:06 ` Martin Steigerwald
2020-02-01  1:00 ` Qu Wenruo
2020-02-02 17:52 ` David Sterba
     [not found]   ` <CAKhhfD7S=kcKLRURdNFZ8H4beS8=XjFvnOQXche7+SVOGFGC_w@mail.gmail.com>
2020-02-19  9:17     ` Martin Steigerwald
2020-02-19 13:43       ` Marc MERLIN
2020-02-19 14:31         ` David Sterba
2020-02-19 15:36           ` Marc MERLIN
2020-02-19 17:50             ` Roman Mamedov
2020-02-19 22:21               ` Martin Steigerwald
2020-02-20 21:46             ` Marc MERLIN [this message]
2020-02-21  5:38               ` Marc MERLIN
2020-02-21  5:45                 ` Roman Mamedov
2020-02-21 23:07                   ` btrfs filled up dm-thin and df%: shows 8.4TB of data used when I'm only using 10% of that Marc MERLIN
2020-02-21 23:17                     ` How to roll back btrfs filesystem a few revisions? Marc MERLIN
2020-02-21 23:47                       ` Josef Bacik
2020-02-22  0:08                         ` Marc MERLIN
2020-02-22  0:36                           ` Josef Bacik
2020-02-21 23:43                     ` btrfs filled up dm-thin and df%: shows 8.4TB of data used when I'm only using 10% of that Josef Bacik
2020-02-22  0:01                       ` Marc MERLIN
2020-02-22  0:43                         ` Josef Bacik
2020-02-22  1:06                         ` Marc MERLIN
2020-02-22  1:23                           ` Marc MERLIN
2020-02-22 14:51                             ` Marc MERLIN
2020-02-22 14:52                               ` Josef Bacik
2020-02-22 15:24                                 ` Marc MERLIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200220214649.GD26873@merlins.org \
    --to=marc@merlins.org \
    --cc=dsterba@suse.cz \
    --cc=josef@toxicpanda.com \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=martin@lichtvoll.de \
    --cc=rm@romanrm.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox