Re: [PATCH v2 1/3] Btrfs: move all reflink implementation code into its own file

[David Sterba <dsterba@suse.cz>]

On Fri, Feb 21, 2020 at 11:05:08AM +0000, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> The reflink code is quite large and has been living in ioctl.c since ever.
> It has grown over the years after many bug fixes and improvements, and
> since I'm planning on making some further improvements on it, it's time
> to get it better organized by moving into its own file, reflink.c
> (similar to what xfs does for example).
> 
> This change only moves the code out of ioctl.c into the new file, it
> doesn't do any other change.

Makes sense.

> --- a/fs/btrfs/ctree.h
> +++ b/fs/btrfs/ctree.h
> @@ -2989,6 +2989,8 @@ int btrfs_dirty_pages(struct inode *inode, struct page **pages,
>  		      size_t num_pages, loff_t pos, size_t write_bytes,
>  		      struct extent_state **cached);
>  int btrfs_fdatawrite_range(struct inode *inode, loff_t start, loff_t end);
> +
> +/* reflink.c */
>  loff_t btrfs_remap_file_range(struct file *file_in, loff_t pos_in,
>  			      struct file *file_out, loff_t pos_out,
>  			      loff_t len, unsigned int remap_flags);

Let's create reflink.h with all the relevant declarations for reflink
moved out of ctree.h too.

I see only BTRFS_MAX_DEDUPE_LEN and declaration of btrfs_remap_file_range,
that's not much for now but it's cleaner and for future extensions.
Thanks.