From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: Fix uninitialized ret in btrfsic_process_superblock_dev_mirror
Date: Mon, 24 Feb 2020 16:16:21 +0100 [thread overview]
Message-ID: <20200224151621.GV2902@twin.jikos.cz> (raw)
In-Reply-To: <e51b2144-a4a1-2c10-3bf8-991a1347dbc9@suse.com>
On Mon, Feb 24, 2020 at 02:57:00PM +0200, Nikolay Borisov wrote:
>
>
> On 24.02.20 г. 14:56 ч., Nikolay Borisov wrote:
> > We could return ret uninitlaized in case of success. Before the code was
> > returning 0 explicitly in case of success but now it will be a random value from
> > the stack. That's due to ret being set only in error conditions.
> >
> > Signed-off-by: Nikolay Borisov <nborisov@suse.com>
>
> This ideally has to be folded in:
> 5a03d907a555 ("btrfs: remove buffer_heads form super block mirror
> integrity checking")
Folded and pushed, thanks.
next prev parent reply other threads:[~2020-02-24 15:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 12:56 [PATCH] btrfs: Fix uninitialized ret in btrfsic_process_superblock_dev_mirror Nikolay Borisov
2020-02-24 12:57 ` Nikolay Borisov
2020-02-24 15:16 ` David Sterba [this message]
2020-02-24 13:00 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224151621.GV2902@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox