From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 842E5C11D2F for ; Mon, 24 Feb 2020 16:46:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6127D20637 for ; Mon, 24 Feb 2020 16:46:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727950AbgBXQqC (ORCPT ); Mon, 24 Feb 2020 11:46:02 -0500 Received: from mx2.suse.de ([195.135.220.15]:34454 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727673AbgBXQqC (ORCPT ); Mon, 24 Feb 2020 11:46:02 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id B2B87AD19; Mon, 24 Feb 2020 16:46:00 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 0BE19DA727; Mon, 24 Feb 2020 17:45:41 +0100 (CET) Date: Mon, 24 Feb 2020 17:45:41 +0100 From: David Sterba To: Qu Wenruo Cc: linux-btrfs@vger.kernel.org, Josef Bacik Subject: Re: [PATCH v2 2/2] btrfs: qgroup: Remove the unnecesaary spin lock for qgroup_rescan_running|queued Message-ID: <20200224164541.GY2902@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Qu Wenruo , linux-btrfs@vger.kernel.org, Josef Bacik References: <20200207053821.25643-1-wqu@suse.com> <20200207053821.25643-3-wqu@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200207053821.25643-3-wqu@suse.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Fri, Feb 07, 2020 at 01:38:21PM +0800, Qu Wenruo wrote: > Those two members are all protected by > btrfs_fs_info::qgroup_rescan_lock, thus no need for the extra spinlock. Two members refers to btrfs_fs_info::qgroup_rescan_lock and what else? Byt the subject it's something 'queued' but I can't find what it's referring to.