From: Christoph Hellwig <hch@lst.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
Lu Fengqi <lufq.fnst@cn.fujitsu.com>,
linux-btrfs@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
David Sterba <dsterba@suse.cz>
Subject: Re: [PATCH v4 1/4] uuid: Add inline helpers to import / export UUIDs
Date: Mon, 24 Feb 2020 18:41:26 +0100 [thread overview]
Message-ID: <20200224174126.GA7771@lst.de> (raw)
In-Reply-To: <20200224153752.35063-2-andriy.shevchenko@linux.intel.com>
On Mon, Feb 24, 2020 at 05:37:49PM +0200, Andy Shevchenko wrote:
> Sometimes we may need to import UUID from or export to the raw buffer,
> which is provided outside of kernel and can't be declared as UUID type.
> With current API this operation will require an explicit casting
> to one of UUID types and length, that is always a constant derived as sizeof
> the certain UUID type.
>
> Provide a helpful set of inline helpers to minimize developer's effort
> in the cases when raw buffers are involved.
>
> Suggested-by: David Sterba <dsterba@suse.cz>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
No a huge fan of these trivial memcpy wrappers, but they also don't
seem entirely horrible:
Acked-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-02-24 17:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 15:37 [PATCH v4 0/4] btrfs: bypass UUID API aliasing Andy Shevchenko
2020-02-24 15:37 ` [PATCH v4 1/4] uuid: Add inline helpers to import / export UUIDs Andy Shevchenko
2020-02-24 17:41 ` Christoph Hellwig [this message]
2020-02-24 15:37 ` [PATCH v4 2/4] uuid: Provide a GUID generator for raw buffer Andy Shevchenko
2020-02-24 17:41 ` Christoph Hellwig
2020-02-24 15:37 ` [PATCH v4 3/4] Btrfs: Switch to use new generic UUID API Andy Shevchenko
2020-02-24 17:42 ` Christoph Hellwig
2020-02-24 15:37 ` [PATCH v4 4/4] uuid: Remove no more needed macro Andy Shevchenko
2020-02-24 17:42 ` Christoph Hellwig
2020-02-24 17:26 ` [PATCH v4 0/4] btrfs: bypass UUID API aliasing David Sterba
2020-02-24 17:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224174126.GA7771@lst.de \
--to=hch@lst.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=lufq.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox