From: David Sterba <dsterba@suse.cz>
To: fdmanana@kernel.org
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: fix crash during unmount due to race with delayed inode workers
Date: Fri, 28 Feb 2020 17:20:16 +0100 [thread overview]
Message-ID: <20200228162016.GP2902@twin.jikos.cz> (raw)
In-Reply-To: <20200228130436.26128-1-fdmanana@kernel.org>
On Fri, Feb 28, 2020 at 01:04:36PM +0000, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> During unmount we can have a job from the delayed inode items work queue
> still running, that can lead to at least two bad things_
>
> 1) A crash, because the worker can try to create a transaction just
> after the fs roots were freed;
>
> 2) A transaction leak, because the worker can create a transaction
> before the fs roots are freed and just after we committed the last
> transaction and after we stopped the transaction kthread.
...
> + * This is a very rare case.
Added to misc-next, thanks. I'll tag it for stable but will not put to
5.6-rc queue given that it's very rare, unless requested.
prev parent reply other threads:[~2020-02-28 16:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 13:04 [PATCH] Btrfs: fix crash during unmount due to race with delayed inode workers fdmanana
2020-02-28 16:20 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228162016.GP2902@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox