From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82EE5C3F2C6 for ; Tue, 3 Mar 2020 17:29:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5A8D5208C3 for ; Tue, 3 Mar 2020 17:29:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730369AbgCCR3l (ORCPT ); Tue, 3 Mar 2020 12:29:41 -0500 Received: from mx2.suse.de ([195.135.220.15]:43072 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730368AbgCCR3l (ORCPT ); Tue, 3 Mar 2020 12:29:41 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 9F618B028; Tue, 3 Mar 2020 17:29:39 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 8A53FDA7AE; Tue, 3 Mar 2020 18:29:17 +0100 (CET) Date: Tue, 3 Mar 2020 18:29:17 +0100 From: David Sterba To: Qu Wenruo Cc: linux-btrfs@vger.kernel.org Subject: Re: [PATCH v2 05/10] btrfs: relocation: Refactor tree backref processing into its own function Message-ID: <20200303172917.GK2902@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Qu Wenruo , linux-btrfs@vger.kernel.org References: <20200302094553.58827-1-wqu@suse.com> <20200302094553.58827-6-wqu@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200302094553.58827-6-wqu@suse.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Mon, Mar 02, 2020 at 05:45:48PM +0800, Qu Wenruo wrote: > build_backref_tree() function is painfully long, as it has 3 big parts: > - Tree backref handling > - Weaving backref nodes > - Useless nodes pruning So this is the first patch that mentions the 'useless' nodes. This seems like a misnomer or confusing at best but I haven't read enough code to see if it's really the right name. Also the term 'weaving', that seems to be added by you. Did you mean splicing or merging?