From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: dsterba@suse.cz, David Sterba <dsterba@suse.com>,
Qu Wenruo <quwenruo.btrfs@gmx.com>,
linux-btrfs@vger.kernel.org, Nikolay Borisov <nborisov@suse.com>
Subject: Re: [PATCH] btrfs-progs: convert, warn if converting a fs which won't mount
Date: Wed, 4 Mar 2020 14:32:44 +0100 [thread overview]
Message-ID: <20200304133244.GP2902@twin.jikos.cz> (raw)
In-Reply-To: <fc02b904-5af5-035f-bb62-a2982409ffbe@oracle.com>
On Wed, Mar 04, 2020 at 10:14:20AM +0800, Anand Jain wrote:
> > the conversion.
> >
> > I've tried mkfs.ext4 with 64k block size and it warns and in the
> > interactive session wants to confirm that by the user:
> >
> > $ mkfs.ext4 -b 64k img
> > Warning: blocksize 65536 not usable on most systems.
> > mke2fs 1.45.5 (07-Jan-2020)
> > img contains a ext4 file system
> > created on Tue Mar 3 18:41:46 2020
> > Proceed anyway? (y,N) y
> > mkfs.ext4: 65536-byte blocks too big for system (max 4096)
> > Proceed anyway? (y,N) y
> > Warning: 65536-byte blocks too big for system (max 4096), forced to continue
> > Creating filesystem with 32768 64k blocks and 32768 inodes
> >
> > Allocating group tables: done
> > Writing inode tables: done
> > Creating journal (4096 blocks): done
> > Writing superblocks and filesystem accounting information: done
> >
>
> Just warn is reasonable. But I don't think you meant to introduce
> interactive part similar to mkfs.ext4 in btrfs-convert?
No I haven't meant that. So let's go with the warning.
next prev parent reply other threads:[~2020-03-04 13:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 8:03 [PATCH] btrfs-progs: convert, warn if converting a fs which won't mount Anand Jain
2020-02-28 8:13 ` Nikolay Borisov
2020-02-28 10:17 ` Roman Mamedov
2020-02-28 8:27 ` Qu Wenruo
2020-02-28 9:06 ` Anand Jain
2020-02-28 9:11 ` Qu Wenruo
2020-03-03 17:44 ` David Sterba
2020-03-04 2:14 ` Anand Jain
2020-03-04 2:55 ` Qu Wenruo
2020-03-04 13:32 ` David Sterba [this message]
2020-03-04 15:22 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200304133244.GP2902@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox