From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A3ABC3F2CE for ; Wed, 4 Mar 2020 19:25:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1695E20870 for ; Wed, 4 Mar 2020 19:25:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728512AbgCDTZi (ORCPT ); Wed, 4 Mar 2020 14:25:38 -0500 Received: from mx2.suse.de ([195.135.220.15]:42794 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726440AbgCDTZi (ORCPT ); Wed, 4 Mar 2020 14:25:38 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 1765EAD41; Wed, 4 Mar 2020 19:25:37 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 620DBDA7B4; Wed, 4 Mar 2020 20:25:14 +0100 (CET) Date: Wed, 4 Mar 2020 20:25:14 +0100 From: David Sterba To: Nikolay Borisov Cc: linux-btrfs@vger.kernel.org Subject: Re: [PATCH] btrfs: Remove impossible BUG_ON in get_tree_block_key Message-ID: <20200304192514.GZ2902@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Nikolay Borisov , linux-btrfs@vger.kernel.org References: <20200304150447.19582-1-nborisov@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200304150447.19582-1-nborisov@suse.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Wed, Mar 04, 2020 at 05:04:47PM +0200, Nikolay Borisov wrote: > relocate_tree_blocks calls get_tree_block_key for a block iff that block > has its ->key_ready equal false. Thus the BUG_ON in the latter function > cannot ever be triggered so remove it. > > Signed-off-by: Nikolay Borisov Added to misc-next, thanks.