From: David Sterba <dsterba@suse.cz>
To: Filipe Manana <fdmanana@kernel.org>
Cc: Josef Bacik <josef@toxicpanda.com>,
linux-btrfs <linux-btrfs@vger.kernel.org>,
Filipe Manana <fdmanana@suse.com>
Subject: Re: [PATCH v3 3/3] Btrfs: implement full reflink support for inline extents
Date: Thu, 5 Mar 2020 15:19:59 +0100 [thread overview]
Message-ID: <20200305141959.GC2902@twin.jikos.cz> (raw)
In-Reply-To: <CAL3q7H7twdkw1LphkCWexABjT=WGxKHQvq7hsq+99VF5KJE3Uw@mail.gmail.com>
On Thu, Mar 05, 2020 at 11:57:52AM +0000, Filipe Manana wrote:
> So this actually isn't safe.
>
> It can bring back the race that leads to file extent items with
> overlapping ranges. Not because of the hole detection part but because
> of the part where we copy extent items from the fs/subvolume tree into
> the log tree using btrfs_search_forward(), as we copy all extent
> items, including the ones outside the fsync range - so we could race
> in the same way as we did during hole detection with ordered extent
> completion for ordered extents outside the range.
>
> I'll have to rework this a bit.
Ok, I'll remove the branch from for-next. Thanks.
next prev parent reply other threads:[~2020-03-05 14:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 17:13 [PATCH v3 3/3] Btrfs: implement full reflink support for inline extents fdmanana
2020-03-03 21:19 ` Josef Bacik
2020-03-05 11:57 ` Filipe Manana
2020-03-05 14:19 ` David Sterba [this message]
2020-03-05 15:03 ` Filipe Manana
2020-03-05 16:38 ` David Sterba
2020-03-05 17:29 ` Filipe Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305141959.GC2902@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fdmanana@kernel.org \
--cc=fdmanana@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox