From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75681C18E5A for ; Wed, 11 Mar 2020 00:40:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 41E86215A4 for ; Wed, 11 Mar 2020 00:40:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727768AbgCKAkj (ORCPT ); Tue, 10 Mar 2020 20:40:39 -0400 Received: from mx2.suse.de ([195.135.220.15]:50852 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727484AbgCKAkj (ORCPT ); Tue, 10 Mar 2020 20:40:39 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 32836B17A; Wed, 11 Mar 2020 00:40:38 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id D8016DA7A7; Wed, 11 Mar 2020 01:40:12 +0100 (CET) Date: Wed, 11 Mar 2020 01:40:12 +0100 From: David Sterba To: Roman Gushchin Cc: Josef Bacik , Chris Mason , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, Rik van Riel Subject: Re: [PATCH v3] btrfs: implement migratepage callback Message-ID: <20200311004012.GC12659@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Roman Gushchin , Josef Bacik , Chris Mason , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, Rik van Riel References: <20200305005735.583008-1-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200305005735.583008-1-guro@fb.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Wed, Mar 04, 2020 at 04:57:35PM -0800, Roman Gushchin wrote: > Currently btrfs doesn't provide a migratepage callback. It means that > fallback_migrate_page() is used to migrate btrfs pages. The callback exists for the metadata pages (btree_migratepage), so I've added 'for data pages' where appropriate. > fallback_migrate_page() cannot move dirty pages, instead it tries to > flush them (in sync mode) or just fails (in async mode). > > In the sync mode pages which are scheduled to be processed by > btrfs_writepage_fixup_worker() can't be effectively flushed by the > migration code, because there is no established way to wait for the > completion of the delayed work. > > It all leads to page migration failures. > > To fix it the patch implements a btrs-specific migratepage callback, > which is similar to iomap_migrate_page() used by some other fs, except > it does take care of the PagePrivate2 flag which is used for data > ordering purposes. > > v3: fixed the build issue once again > v2: fixed the build issue found by the kbuild test robot > > Signed-off-by: Roman Gushchin > Reviewed-by: Chris Mason Added to devel queue, thanks.