From: David Sterba <dsterba@suse.cz>
To: fdmanana@kernel.org
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: fix log context list corruption after rename whiteout error
Date: Wed, 11 Mar 2020 01:59:27 +0100 [thread overview]
Message-ID: <20200311005927.GE12659@twin.jikos.cz> (raw)
In-Reply-To: <20200310121353.11764-1-fdmanana@kernel.org>
On Tue, Mar 10, 2020 at 12:13:53PM +0000, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> During a rename whiteout, if btrfs_whiteout_for_rename() returns an error
> we can end up returning from btrfs_rename() with the log context object
> still in the root's log context list - this happens if 'sync_log' was
> set to true before we called btrfs_whiteout_for_rename() and it is
> dangerous because we end up with a corrupt linked list (root->log_ctxs)
> as the log context object was allocated on the stack.
>
> After btrfs_rename() returns, any task that is running btrfs_sync_log()
> concurrently can end up crashing because that linked list is traversed by
> btrfs_sync_log() (through btrfs_remove_all_log_ctxs()). That results in
> the same issue that commit e6c617102c7e4 ("Btrfs: fix log context list
> corruption after rename exchange operation") fixed.
>
> Fixes: d4682ba03ef618 ("Btrfs: sync log after logging new name")
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
Added to misc-next, thanks.
prev parent reply other threads:[~2020-03-11 0:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 12:13 [PATCH] Btrfs: fix log context list corruption after rename whiteout error fdmanana
2020-03-11 0:59 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311005927.GE12659@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox