From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/3] btrfs: Remove BTRFS_SUBVOL_CREATE_ASYNC support
Date: Fri, 13 Mar 2020 22:28:01 +0100 [thread overview]
Message-ID: <20200313212801.GR12659@twin.jikos.cz> (raw)
In-Reply-To: <20200313152320.22723-2-nborisov@suse.com>
On Fri, Mar 13, 2020 at 05:23:18PM +0200, Nikolay Borisov wrote:
> --- a/include/uapi/linux/btrfs.h
> +++ b/include/uapi/linux/btrfs.h
> @@ -36,7 +36,6 @@ struct btrfs_ioctl_vol_args {
> #define BTRFS_DEVICE_PATH_NAME_MAX 1024
> #define BTRFS_SUBVOL_NAME_MAX 4039
>
> -#define BTRFS_SUBVOL_CREATE_ASYNC (1ULL << 0)
Removing it completely is probably fine but the 1st bit must not be
reused anytime soon, so at least some comment should be left here.
> #define BTRFS_SUBVOL_RDONLY (1ULL << 1)
> #define BTRFS_SUBVOL_QGROUP_INHERIT (1ULL << 2)
>
> @@ -45,8 +44,7 @@ struct btrfs_ioctl_vol_args {
> #define BTRFS_SUBVOL_SPEC_BY_ID (1ULL << 4)
>
> #define BTRFS_VOL_ARG_V2_FLAGS_SUPPORTED \
> - (BTRFS_SUBVOL_CREATE_ASYNC | \
> - BTRFS_SUBVOL_RDONLY | \
> + (BTRFS_SUBVOL_RDONLY | \
> BTRFS_SUBVOL_QGROUP_INHERIT | \
> BTRFS_DEVICE_SPEC_BY_ID | \
> BTRFS_SUBVOL_SPEC_BY_ID)
> @@ -116,8 +114,7 @@ struct btrfs_ioctl_qgroup_limit_args {
>
> /* Supported flags for BTRFS_IOC_SNAP_CREATE_V2 and BTRFS_IOC_SUBVOL_CREATE_V2 */
> #define BTRFS_SUBVOL_CREATE_ARGS_MASK \
> - (BTRFS_SUBVOL_CREATE_ASYNC | \
> - BTRFS_SUBVOL_RDONLY | \
> + (BTRFS_SUBVOL_RDONLY | \
So this would catch any potential use of the flag and the ioctl can
simply remove all the related code. Ok.
next prev parent reply other threads:[~2020-03-13 21:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 15:23 [PATCH 0/3] Removal of BTRFS_SUBVOL_CREATE_ASYNC support Nikolay Borisov
2020-03-13 15:23 ` [PATCH 1/3] btrfs: Remove " Nikolay Borisov
2020-03-13 21:28 ` David Sterba [this message]
2020-03-13 15:23 ` [PATCH 2/3] btrfs: Remove transid argument from btrfs_ioctl_snap_create_transid Nikolay Borisov
2020-03-13 21:32 ` David Sterba
2020-03-13 15:23 ` [PATCH 3/3] btrfs: Remove async_transid btrfs_mksubvol/create_subvol/create_snapshot Nikolay Borisov
2020-03-16 17:01 ` [PATCH 0/3] Removal of BTRFS_SUBVOL_CREATE_ASYNC support David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313212801.GR12659@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox