From: David Sterba <dsterba@suse.cz>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Qu Wenruo <wqu@suse.com>,
u-boot@lists.denx.de, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/2] uboot: fs/btrfs: Fix LZO false decompression error caused by pending zero
Date: Thu, 19 Mar 2020 14:56:42 +0100 [thread overview]
Message-ID: <20200319135641.GB12659@twin.jikos.cz> (raw)
In-Reply-To: <49c5af50-8c09-9b49-ab44-ebe5eb9a652c@gmail.com>
On Thu, Mar 19, 2020 at 02:33:28PM +0100, Matthias Brugger wrote:
> > dlen -= out_len;
> >
> > res += out_len;
> > +
> > + /*
> > + * If the 4 bytes header does not fit to the rest of the page we
> > + * have to move to next one, or we read some garbage.
> > + */
> > + mod_page = tot_in % PAGE_SIZE;
>
> in U-Boot we use 4K page sizes, but the OS could use another page size (16K or
> 64k). Would we need to adapt that code to reflect which page size is used on the
> medium we want to access?
Yes, it is the 'sectorsize' as it's set up in fs_info or it's equivalent
in uboot. For kernel the page size == sectorsize is kind of implicit and
verified at mount time.
next prev parent reply other threads:[~2020-03-19 13:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 12:30 [PATCH 0/2] uboot: fs/btrfs: Fix read error on LZO compressed extents Qu Wenruo
2020-03-19 12:30 ` [PATCH 1/2] uboot: fs/btrfs: Use LZO_LEN to replace immediate number Qu Wenruo
2020-03-19 12:30 ` [PATCH 2/2] uboot: fs/btrfs: Fix LZO false decompression error caused by pending zero Qu Wenruo
2020-03-19 13:33 ` Matthias Brugger
2020-03-19 13:56 ` David Sterba [this message]
2020-03-19 14:34 ` Matthias Brugger
2020-03-19 16:28 ` David Sterba
2020-03-24 11:03 ` Qu Wenruo
2020-03-25 7:58 ` Marek Behun
2020-03-24 11:03 ` Qu Wenruo
-- strict thread matches above, loose matches on Subject: below --
2020-03-19 12:33 [PATCH 0/2] uboot: fs/btrfs: Fix read error on LZO compressed extents Qu Wenruo
2020-03-19 12:33 ` [PATCH 2/2] uboot: fs/btrfs: Fix LZO false decompression error caused by pending zero Qu Wenruo
[not found] ` <20200325090900.276eef09@nic.cz>
[not found] ` <6b42f7e0-626f-67da-e9ba-fa4d9db8dd15@gmx.com>
[not found] ` <20200325120020.65427217@nic.cz>
2020-03-25 11:32 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319135641.GB12659@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=u-boot@lists.denx.de \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox