From: David Sterba <dsterba@suse.cz>
To: fdmanana@kernel.org
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: fix removal of raid[56|1c34} incompat flags after removing block group
Date: Fri, 20 Mar 2020 21:27:28 +0100 [thread overview]
Message-ID: <20200320202728.GI12659@twin.jikos.cz> (raw)
In-Reply-To: <20200320184348.845248-1-fdmanana@kernel.org>
On Fri, Mar 20, 2020 at 06:43:48PM +0000, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> We are incorrectly dropping the raid56 and raid1c34 incompat flags when
> there are still raid56 and raid1c34 block groups, not when we do not any
> of those anymore. The logic just got unintentionally broken after adding
> the support for the raid1c34 modes.
>
> Fix this by clear the flags only if we do not have block groups with the
> respective profiles.
>
> Fixes: 9c907446dce3 ("btrfs: drop incompat bit for raid1c34 after last block group is gone")
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
Thanks, that was a stupid mistake. As it's a regression fix, I'll send
as an rc fix.
next prev parent reply other threads:[~2020-03-20 20:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 18:43 [PATCH] Btrfs: fix removal of raid[56|1c34} incompat flags after removing block group fdmanana
2020-03-20 20:27 ` David Sterba [this message]
2020-03-21 1:43 ` Qu Wenruo
2020-03-21 17:45 ` David Sterba
2020-03-22 0:42 ` Qu Wenruo
2020-03-23 19:28 ` David Sterba
2020-03-24 7:03 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320202728.GI12659@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox