From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/6] btrfs-progs: Fixes for valgrind errors during fsck-tests
Date: Fri, 27 Mar 2020 16:27:41 +0100 [thread overview]
Message-ID: <20200327152741.GN5920@twin.jikos.cz> (raw)
In-Reply-To: <b4df0751-2d8d-43c1-5156-4f7eeab5807e@suse.com>
On Thu, Mar 26, 2020 at 08:59:16AM +0800, Qu Wenruo wrote:
>
>
> On 2020/3/25 下午10:42, David Sterba wrote:
> > On Tue, Mar 24, 2020 at 06:53:09PM +0800, Qu Wenruo wrote:
> >> This patchset can be fetched from github:
> >> https://github.com/adam900710/btrfs-progs/tree/valgrind_fixes
> >>
> >> Inspired by that long-existing-but-I-can't-reproduce v5.1 bug, I will
> >> never trust D=asan/D=uban anymore, and run valgrind on all fsck-tests.
> >>
> >> The patchset is the result from the latest valgrind runs.
> >>
> >> The first patch is to make "make INSTRUMENT=valgrind test-fsck" run
> >> smoothly without false alerts due to mount/umount failure with valgrind.
> >
> > Thanks, that's great. In addition to that, all commands that use the
> > SUDO_HELPER/root_helper won't pass through valgrind. For maximum
> > coverage we might want to remove the helper from the subcommands of
> > 'btrfs'. From a quick scan I found a lot of them and I'm not sure that
> > all are required. There's a lot of copy&paste in the tests, so that
> > would have to be cleaned up, or we leave it as it is and run the whole
> > tests under root.
>
> The root fix is, like what we did for lowmem mode, injecting valgrind to
> proper location.
>
> Currently I take a shortcut to reuse current infrastructure, but the
> root fix would need to inject INSTRUMENT directly before
> "btrfs/mkfs.btrfs/btrfs-convert", so that sudo_helper won't be a problem.
That's a great idea. For some reason I thought that valgrind refused to
work under root but that's not true. Injecting the instrumentation only
to the tools built from git is exactly what we want.
prev parent reply other threads:[~2020-03-27 15:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 10:53 [PATCH 0/6] btrfs-progs: Fixes for valgrind errors during fsck-tests Qu Wenruo
2020-03-24 10:53 ` [PATCH 1/6] btrfs-progs: tests/common: Don't call INSTRUMENT on mount command Qu Wenruo
2020-03-24 10:53 ` [PATCH 2/6] btrfs-progs: check/original: Fix uninitialized stack memory access for deal_root_from_list() Qu Wenruo
2020-03-24 10:53 ` [PATCH 3/6] btrfs-progs: check/original: Fix uninitialized memory for newly allocated data_backref Qu Wenruo
2020-03-24 10:53 ` [PATCH 4/6] btrfs-progs: check/original: Fix uninitialized return value from btrfs_write_dirty_block_groups() Qu Wenruo
2020-03-24 10:53 ` [PATCH 5/6] btrfs-progs: check/original: Fix uninitialized extent buffer contents Qu Wenruo
2020-03-24 10:53 ` [PATCH 6/6] btrfs-progs: extent-tree: Fix wrong post order rb tree cleanup for block groups Qu Wenruo
2020-03-25 14:42 ` [PATCH 0/6] btrfs-progs: Fixes for valgrind errors during fsck-tests David Sterba
2020-03-26 0:59 ` Qu Wenruo
2020-03-27 15:27 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327152741.GN5920@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox