From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0F22C2D0F3 for ; Wed, 1 Apr 2020 16:01:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4F5620784 for ; Wed, 1 Apr 2020 16:01:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733018AbgDAQB0 (ORCPT ); Wed, 1 Apr 2020 12:01:26 -0400 Received: from mx2.suse.de ([195.135.220.15]:48082 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732651AbgDAQB0 (ORCPT ); Wed, 1 Apr 2020 12:01:26 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 907C7ACB1; Wed, 1 Apr 2020 16:01:24 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 7F097DA727; Wed, 1 Apr 2020 18:00:50 +0200 (CEST) Date: Wed, 1 Apr 2020 18:00:50 +0200 From: David Sterba To: "Gustavo A. R. Silva" , osandov@fb.com Cc: Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] btrfs: inode: Fix uninitialized variable bug Message-ID: <20200401160050.GV5920@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, "Gustavo A. R. Silva" , osandov@fb.com, Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200327200135.GA3472@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200327200135.GA3472@embeddedor> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Fri, Mar 27, 2020 at 03:01:35PM -0500, Gustavo A. R. Silva wrote: > geom.len is being used without being properly initialized, previously. > > Fix this by placing ASSERT(geom.len <= INT_MAX); after geom.len has been > initialized. > > Addresses-Coverity-ID: 1491912 ("Uninitialized scalar variable") > Fixes: 1eb52c8bd8d6 ("btrfs: get rid of one layer of bios in direct I/O") Thanks. This is in a development branch so the fixup can be folded in, we're expecting more revisions of the patchset anyway. CCing Omar.