From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Qu Wenruo <wqu@suse.com>
Cc: kbuild-all@lists.01.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] btrfs: Only require sector size alignment for parent eb bytenr
Date: Fri, 3 Apr 2020 11:11:31 +0300 [thread overview]
Message-ID: <20200403081131.GV2001@kadam> (raw)
In-Reply-To: <20200326055403.22748-1-wqu@suse.com>
Hi Qu,
url: https://github.com/0day-ci/linux/commits/Qu-Wenruo/btrfs-Only-require-sector-size-alignment-for-parent-eb-bytenr/20200327-034045
base: https://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git next
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
fs/btrfs/extent-tree.c:1178 btrfs_get_extent_inline_ref_type() warn: '0x' prefix is confusing together with '%lu' specifier
fs/btrfs/extent-tree.c:1178 btrfs_get_extent_inline_ref_type() warn: argument 4 to %lu specifier is cast from pointer
Old smatch warnings:
fs/btrfs/extent-tree.c:6343 update_block_group() warn: inconsistent indenting
fs/btrfs/extent-tree.c:7620 find_free_extent() warn: inconsistent indenting
# https://github.com/0day-ci/linux/commit/8a07080e7e5051c75e67e30bf635fc230b2ab720
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 8a07080e7e5051c75e67e30bf635fc230b2ab720
vim +1178 fs/btrfs/extent-tree.c
64ecdb647ddb83 Liu Bo 2017-08-18 1166 */
64ecdb647ddb83 Liu Bo 2017-08-18 1167 if (offset &&
8a07080e7e5051 Qu Wenruo 2020-03-26 1168 IS_ALIGNED(offset, eb->fs_info->sectorsize))
64ecdb647ddb83 Liu Bo 2017-08-18 1169 return type;
64ecdb647ddb83 Liu Bo 2017-08-18 1170 }
167ce953ca55bd Liu Bo 2017-08-18 1171 } else {
167ce953ca55bd Liu Bo 2017-08-18 1172 ASSERT(is_data == BTRFS_REF_TYPE_ANY);
167ce953ca55bd Liu Bo 2017-08-18 1173 return type;
167ce953ca55bd Liu Bo 2017-08-18 1174 }
167ce953ca55bd Liu Bo 2017-08-18 1175 }
167ce953ca55bd Liu Bo 2017-08-18 1176
167ce953ca55bd Liu Bo 2017-08-18 1177 btrfs_print_leaf((struct extent_buffer *)eb);
8a07080e7e5051 Qu Wenruo 2020-03-26 @1178 btrfs_err(eb->fs_info,
8a07080e7e5051 Qu Wenruo 2020-03-26 1179 "eb %llu iref 0x%lu invalid extent inline ref type %d",
^^^^^
8a07080e7e5051 Qu Wenruo 2020-03-26 1180 eb->start, (unsigned long)iref, type);
^^^^^^^^^^^^^^^^^^^
0x indicates hex, but this is decimal. But use %p for pointers so that
the can be hidden to people without enough privilege. #kernelHardenning
167ce953ca55bd Liu Bo 2017-08-18 1181 WARN_ON(1);
167ce953ca55bd Liu Bo 2017-08-18 1182
167ce953ca55bd Liu Bo 2017-08-18 1183 return BTRFS_REF_TYPE_INVALID;
167ce953ca55bd Liu Bo 2017-08-18 1184 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next prev parent reply other threads:[~2020-04-03 8:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 5:54 [PATCH v2] btrfs: Only require sector size alignment for parent eb bytenr Qu Wenruo
2020-04-03 8:11 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-08-26 9:26 Qu Wenruo
2020-08-26 14:18 ` Josef Bacik
2020-08-26 22:51 ` Qu Wenruo
2020-09-03 11:44 ` David Sterba
2020-09-03 11:53 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403081131.GV2001@kadam \
--to=dan.carpenter@oracle.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).